Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore invalid CSS that affects the CSS of subsequent blocks #3199

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

Arukuen
Copy link
Contributor

@Arukuen Arukuen commented May 30, 2024

fixes #3164

notes

Copy link

github-actions bot commented May 30, 2024

🤖 Pull request artifacts

file commit
pr3199-stackable-3199-merge.zip 1aa3a4a

github-actions bot added a commit that referenced this pull request May 30, 2024
Copy link
Contributor

@bfintal bfintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the return '' here stops the css from working (because it stops prepending the necessary CSS selector). I think the better way to fix this is to still continue prepending the necessary CSS selector even if a nested selector is used.

CSS selector nesting is now allowed in the CSS standard, so we should allow it also.

github-actions bot added a commit that referenced this pull request Jun 15, 2024
@bfintal
Copy link
Contributor

bfintal commented Jun 19, 2024

@andeng1106 we need to check if media queries (and shortcut media queries @media mobile still work

@andeng1106
Copy link

andeng1106 commented Jun 20, 2024

Issue is now fixed. I just have one query:

@andeng1106 we need to check if media queries (and shortcut media queries @media mobile still work

@bfintal media queries are still working but shortcut media queries (@media mobile) is not working anymore on frontend since 3.13.1 and older versions

Screen.Recording.2024-06-20.at.11.mp4

@bfintal bfintal merged commit 100f6fe into develop Jun 24, 2024
1 of 6 checks passed
@bfintal bfintal deleted the fix/3164-invalid-custom-css branch June 24, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entering invalid Custom CSS can break block styles
3 participants