Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the remaining links Clickable(Hyperlink) in the generated Resume(NOT PDF) and changing color of hyperlinks. #34

Closed
kaushiksriram16 opened this issue Aug 17, 2020 · 9 comments · Fixed by #35

Comments

@kaushiksriram16
Copy link

Is your feature request related to a problem? Please describe.

  1. In the Generated Resume(NOT PDF) Blog and Github profile links are not hyperlink.
  2. Hyperlinks are not differently colored.

Describe the solution you'd like

  1. Adding anchor tags to the mentioned links
  2. Changing the color of anchor tags in CSS
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.88. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@kaushiksriram16
Copy link
Author

I have sent a pull request of this one.

@tanishq98
Copy link

tanishq98 commented Aug 24, 2020

@ShauryaBhandari @garimasingh128 I would like to work on this issue, as the link of github profile in generated resume (PDF) is not a hyperlink. It should be hyperlink so that a person can go from pdf version to the actual github profile directly by clicking on the hyperlink

@garimasingh128
Copy link
Owner

@kaushiksriram16 has already made a PR. Please look into that PR and mend if something is missing there.

@tanishq98
Copy link

@garimasingh128 have you merged that PR to the hakincodes branch?

@garimasingh128
Copy link
Owner

Not yet. Use this to check the code: https://gist.github.com/adam-p/15413fabef6cffecd897

@tanishq98
Copy link

@kaushiksriram16 has done perfect. But its done only on the web resume.
@garimasingh128 I am doing this on PDF based resume. I am hyperlinking the links of blog and github profile in PDF version. So that the user can directly go to respective addresses directly.

@kaushiksriram16
Copy link
Author

@tanishq98 then that's the issue #30

@tanishq98
Copy link

@tanishq98 then that's the issue #30

Ohh Sorry, I didn't see that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants