Skip to content

Commit 14edfa1

Browse files
chu11mergify[bot]
authored andcommitted
job-manager: reduce amount of checkpointing
Problem: Everytime a queue is enabled/disabled or started/stopped, the current queue state is commited to the KVS for checkpointing. This is an unnecessary amount of checkpointing, as it is only really needed when the job-manager module is unloaded. Solution: Do not sync queue state to the KVS everytime the queue state is modified. Only do this when the module is unloaded. Fixes flux-framework#4804
1 parent 7a139b6 commit 14edfa1

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

src/modules/job-manager/queue.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -619,8 +619,6 @@ static void queue_enable_cb (flux_t *h,
619619
if (jobq_enable (q, enable, disable_reason) < 0)
620620
goto error;
621621
}
622-
if (restart_save_state (queue->ctx) < 0)
623-
flux_log_error (h, "problem saving checkpoint after queue change");
624622
if (flux_respond (h, msg, NULL) < 0)
625623
flux_log_error (h, "error responding to job-manager.queue-enable");
626624
return;
@@ -719,8 +717,6 @@ static void queue_start_cb (flux_t *h,
719717
else
720718
queue_stop (queue, name);
721719
}
722-
if (restart_save_state (queue->ctx) < 0)
723-
flux_log_error (h, "problem saving checkpoint after queue change");
724720
if (flux_respond (h, msg, NULL) < 0)
725721
flux_log_error (h, "error responding to job-manager.queue-start");
726722
return;

0 commit comments

Comments
 (0)