fix: guard against empty BCD encoding scheme to prevent TypeError

Validate the encoding scheme argument in To BCD and From BCD before it is
used. When the scheme is empty or unrecognised (e.g. loaded from a recipe
URL), ENCODING_LOOKUP returns undefined, and accessing properties on it
threw an uncaught TypeError. Throw a friendly OperationError instead.

Adds regression tests covering both operations with an empty scheme.

Author: itxaiohanglover

src/core/operations/FromBCD.mjs

@@ -73,6 +73,9 @@ class FromBCD extends Operation {
         let output = "",
             byteArray;
 
+        if (encoding === undefined)
+            throw new OperationError("Invalid encoding scheme");
+
         // Normalise the input
         switch (inputFormat) {
             case "Nibbles":

src/core/operations/ToBCD.mjs

@@ -67,6 +67,9 @@ class ToBCD extends Operation {
             signed = args[2],
             outputFormat = args[3];
 
+        if (encoding === undefined)
+            throw new OperationError("Invalid encoding scheme");
+
         // Split input number up into separate digits
         const digits = input.toFixed().split("");
 

tests/operations/tests/BCD.mjs

@@ -100,4 +100,28 @@ TestRegister.addTests([
             }
         ]
     },
+    {
+        name: "To BCD: empty encoding scheme throws error",
+        input: "43",
+        expectedError: true,
+        expectedOutput: "To BCD - Invalid encoding scheme",
+        recipeConfig: [
+            {
+                "op": "To BCD",
+                "args": ["", true, false, "Nibbles"]
+            }
+        ]
+    },
+    {
+        name: "From BCD: empty encoding scheme throws error",
+        input: "0100 0011",
+        expectedError: true,
+        expectedOutput: "From BCD - Invalid encoding scheme",
+        recipeConfig: [
+            {
+                "op": "From BCD",
+                "args": ["", true, false, "Nibbles"]
+            }
+        ]
+    },
 ]);