Ash changes #21
Open
Ash changes #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds VPN notice to the homepage
Uses JavaScript for click events instead as selenium does not interact with hidden elements but JavaScript does.
AshGDS
commented
Nov 22, 2023
| @@ -1,7 +1,7 @@ | |||
| class HomeController < ApplicationController | |||
| def index | |||
| @interaction_types = ApplicationController.helpers.interaction_types | |||
| @environments = %w[gov.uk staging.publishing.service.gov.uk integration.publishing.service.gov.uk] | |||
| @environments = %w[integration.publishing.service.gov.uk staging.publishing.service.gov.uk gov.uk] | |||
There was a problem hiding this comment.
I swapped these around, just so that integration is the default option on the form - so production isn't spammed with data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
chrome/chromedriverdocs - it turns out it's no longer tied to your actual version of Chrome, you can install a test version of Chrome and chromedriver so your versions will never become mismatched.event.preventDefault()so that the browser doesn't actually navigate to the link when it clicks it. (see screenshot 1)data-ga4. Now it looks fordata-ga4-event,data-ga4-link, anddata-ga4-formto find elements to click. Each event object is now collapsed by default as well, and has a title which helps show what it is (see screenshot 2).Main content link clicks
'See all events' page