Skip to content

Feature/chat result pub #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

chaeeun037
Copy link
Member

@chaeeun037 chaeeun037 commented Nov 17, 2021

해당 PR은 #6 위에서 진행되었습니다.

대화 종료 페이지(ChatResult) 퍼블리싱

  • assets/image 추가
  • expo-linear-gradient 라이브러리 추가

resolve #3

@chaeeun037 chaeeun037 self-assigned this Nov 17, 2021
Copy link
Contributor

@peanudge peanudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요! 리뷰한번만 체크해주세요! 갠적으로 스타일은 하나의 방식으로 통합하는게 좋아보이네요

@@ -16,5 +18,6 @@
"babel.config.js",
"metro.config.js",
"jest.config.js"
]
],
"extends": "expo/tsconfig.base"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇 이건모죠?

height: 60,
borderRadius: 33.5
}
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stylesheet이랑 styled-component방식을 혼합해서 쓰셨는데 styled component로 처리하는게 좋지않을까요?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[frontend] 대화 종료 페이지 퍼블리싱
2 participants