Skip to content

Using with providers constructed via static method #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
atymic opened this issue Feb 24, 2021 · 0 comments · May be fixed by #182
Open

Using with providers constructed via static method #181

atymic opened this issue Feb 24, 2021 · 0 comments · May be fixed by #182
Assignees
@mikebronner

Comments

@atymic
Copy link
Member

atymic commented Feb 24, 2021

General Information

GeocoderLaravel Version: 4.4.4
PHP Version: 7.3
Operating System and Version: Ubuntu

Issue Description

The here provider is constructed via a static method for new keys (this was to avoid a BC break) but this package only supports constructing via the constructor

Steps to Replicate

Try to use here provider with API keys, get auth issue as it uses the api key as an api code

Stack Trace

[if an error is occuring, provide the complete stack trace here]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikebronner mikebronner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow resolving from container instead of constructing directly atymic/GeocoderLaravel
2 participants
@mikebronner @atymic