Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the CSV provider not skip invalid coordinates, and instead return nil geometries? #1922

Closed
mikemahoney218-usgs opened this issue Feb 5, 2025 · 0 comments · Fixed by #1923
Labels
enhancement New feature or request OGC API - Features OGC API - Features
Milestone

Comments

@mikemahoney218-usgs
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In #967, the CSV provider was changed to skip rows with invalid geometries. This means that pygeoapi filters out data with unknown (or typo'd) geometries.

At the time, there was a question about if this should return a nil geometry instead:
#967 (review)

I personally think it would make sense to use a nil geometry here -- that would allow us to publish data that we know has a geometry, but we don't know what the geometry is.

Describe the solution you'd like
Observations in a CSV with missing or malformed coordinates are given nil geometries.

@mikemahoney218-usgs mikemahoney218-usgs added the enhancement New feature or request label Feb 5, 2025
mikemahoney218-usgs added a commit to mikemahoney218-usgs/pygeoapi that referenced this issue Feb 5, 2025
mikemahoney218-usgs added a commit to mikemahoney218-usgs/pygeoapi that referenced this issue Feb 5, 2025
@tomkralidis tomkralidis added the OGC API - Features OGC API - Features label Feb 8, 2025
@tomkralidis tomkralidis added this to the 0.20.0 milestone Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OGC API - Features OGC API - Features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants