Upgrade Rust to 2024-12-16 (#32566)

GitOrigin-RevId: 003a15e6970b7caba6ac6fdf5ad4121fddc8ba74

Author: goffrie

crates/application/src/application_function_runner/mod.rs

@@ -526,7 +526,7 @@ struct RequestGuard<'a> {
     permit: Option<SemaphorePermit<'a>>,
 }
 
-impl<'a> RequestGuard<'a> {
+impl RequestGuard<'_> {
     async fn acquire_permit(&mut self) -> anyhow::Result<()> {
         let timer = function_waiter_timer(self.limiter.udf_type);
         assert!(
@@ -541,7 +541,7 @@ impl<'a> RequestGuard<'a> {
     }
 }
 
-impl<'a> Drop for RequestGuard<'a> {
+impl Drop for RequestGuard<'_> {
     fn drop(&mut self) {
         // Drop the semaphore permit before updating gauges.
         drop(self.permit.take());

crates/application/src/cache/mod.rs

@@ -584,7 +584,7 @@ impl<'a> WaitingEntryGuard<'a> {
     }
 }
 
-impl<'a> Drop for WaitingEntryGuard<'a> {
+impl Drop for WaitingEntryGuard<'_> {
     fn drop(&mut self) {
         // Remove the cache entry from the cache if still present.
         if let Some(entry_id) = self.entry_id {

crates/application/src/deploy_config.rs

@@ -615,7 +615,7 @@ impl<'a, RT: Runtime> ApplicationInitializerEvaluator<'a, RT> {
 }
 
 #[async_trait]
-impl<'a, RT: Runtime> InitializerEvaluator for ApplicationInitializerEvaluator<'a, RT> {
+impl<RT: Runtime> InitializerEvaluator for ApplicationInitializerEvaluator<'_, RT> {
     async fn evaluate(
         &self,
         path: ComponentDefinitionPath,

crates/application/src/function_log.rs

@@ -1521,7 +1521,7 @@ impl<RT: Runtime> Inner<RT> {
             static LAST_LOGGED_ERROR: Cell<Option<SystemTime>> = const { Cell::new(None) };
         }
         let now = SystemTime::now();
-        let should_log = LAST_LOGGED_ERROR.get().map_or(true, |last_logged| {
+        let should_log = LAST_LOGGED_ERROR.get().is_none_or(|last_logged| {
             now.duration_since(last_logged).unwrap_or(Duration::ZERO) >= Duration::from_secs(10)
         });
         if !should_log {

crates/application/src/lib.rs

@@ -1,5 +1,4 @@
 #![feature(try_blocks)]
-#![feature(lazy_cell)]
 #![feature(iterator_try_collect)]
 #![feature(let_chains)]
 #![feature(coroutines)]

crates/application/src/snapshot_import/parse.rs

@@ -456,7 +456,7 @@ async fn parse_documents_jsonl<'a, R: TokioAsyncRead + Unpin>(
     }
 }
 
-async fn parse_generated_schema<'a, T: ShapeConfig, R: AsyncRead + Unpin>(
+async fn parse_generated_schema<T: ShapeConfig, R: AsyncRead + Unpin>(
     filename: &str,
     mut entry_reader: BufReader<R>,
 ) -> anyhow::Result<GeneratedSchema<T>> {

crates/application/src/snapshot_import/schema_constraints.rs

@@ -25,6 +25,7 @@ use value::{
 /// 2. import does not touch table "bar".
 /// 3. "bar" has a foreign reference to "foo", validated by schema.
 /// 4. when the import commits, "bar" is nonempty.
+///
 /// To prevent this case we throw an error if a schema'd table outside the
 /// import is nonempty and points into the import, and the import changes the
 /// table number.

crates/async_lru/src/lib.rs

@@ -1,4 +1,3 @@
 #![feature(let_chains)]
-#![feature(lazy_cell)]
 pub mod async_lru;
 mod metrics;

crates/authentication/src/lib.rs

@@ -1,4 +1,3 @@
-#![feature(lazy_cell)]
 use std::{
     str::FromStr,
     sync::LazyLock,
@@ -62,8 +61,6 @@ const CONFIG_URL_SUFFIX: &str = ".well-known/jwks.json";
 /// and not user-facing. These API access tokens are constructed from multiple
 /// clients (eg dashboard/cli)
 pub const CONVEX_CONSOLE_API_AUDIENCE: &str = "https://console.convex.dev/api/";
-/// Scopes required for an access token to be considered valid.
-/// Not really used meaningfully yet, but might be in the future.
 
 /// Extract the bearer token from an `Authorization: Bearer` header.
 pub async fn extract_bearer_token(header: Option<String>) -> anyhow::Result<Option<String>> {

crates/cmd_util/src/lib.rs

@@ -1,3 +1,2 @@
-#![feature(lazy_cell)]
 pub mod env;
 pub mod keyvalue;