JS: Fix clearing auth for React strict mode (#28923)

GitOrigin-RevId: c7297d7849c172027694a0838409bfb8945b91de

Author: xixixao

npm-packages/convex/src/react/ConvexAuthState.tsx

@@ -105,10 +105,17 @@ export function ConvexProviderWithAuth({
         setIsConvexAuthenticated((isConvexAuthenticated) =>
           isConvexAuthenticated ? false : null,
         );
-        // Clear timeout later, so that queries from
-        // unmounted child components unsubscribe first
-        // and rerun without auth on the server
-        setTimeout(() => client.clearAuth(), 0);
+      };
+    }
+  }, [isAuthenticated, fetchAccessToken, isLoading, client]);
+
+  // Clear auth later, so that queries from
+  // unmounted child components unsubscribe first
+  // and rerun without auth on the server
+  useLayoutEffect(() => {
+    if (isAuthenticated) {
+      return () => {
+        client.clearAuth();
       };
     }
   }, [isAuthenticated, fetchAccessToken, isLoading, client]);