-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: swipe to change wallets #265
base: master
Are you sure you want to change the base?
Conversation
@im-adithya it works great, but I think it is not intuitive because there is no user feedback when swiping. But how do users find this feature? compare it to the refreshControl which has user feedback. Would a carousel-like component be better? |
I think we can make a slight back and forth animation of the balance so it teases the user to swipe to the left/right, I'll try to add that |
Added a small wiggle animation and also moved the gesture logic to a seperate component ( |
I am not happy with the current implementation because there is no user feedback when they start swiping. Only after the gesture is detected the wallet is switched (which is also not very obvious if they have similar names). It also interfered with the Android system gestures (sometimes I would navigate back when I actually wanted to test wallet switching). Since switching the wallet can now be done directly from the homescreen and I don't see a use case where users would switch back and forth all the time I don't see an immediate need for this other than being a gimmick / playful way to interact. I'd put this on hold for now tbh. |
I tried to move the wallet balance text along when the user swipes it, but that makes the code hard to even understand because there are lot of things in it (the wiggle animation, swipe animation and the balance refresh scroll coming in between if you scroll diagonally (since scroll view catches any kind of downward swipe)
I agree, the recent wallet switching change from the Home screen is already convenient enough 👍 |
I also have another idea where we can show a ChevronDown icon beside the wallet name which opens a dropdown so the user can switch. Just putting it here since I thought of this for #281 and the same component can be reused here (but still it is not reducing any clicks and is unnecessary) |
Fixes #219