Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: swipe to change wallets #265

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

feat: swipe to change wallets #265

wants to merge 6 commits into from

Conversation

im-adithya
Copy link
Member

Fixes #219

@im-adithya im-adithya requested a review from reneaaron February 7, 2025 05:44
@rolznz
Copy link
Contributor

rolznz commented Feb 20, 2025

@im-adithya it works great, but I think it is not intuitive because there is no user feedback when swiping. But how do users find this feature? compare it to the refreshControl which has user feedback. Would a carousel-like component be better?

@im-adithya
Copy link
Member Author

I think we can make a slight back and forth animation of the balance so it teases the user to swipe to the left/right, I'll try to add that

@im-adithya
Copy link
Member Author

Added a small wiggle animation and also moved the gesture logic to a seperate component (GestureWrapper)

@reneaaron
Copy link
Contributor

I am not happy with the current implementation because there is no user feedback when they start swiping. Only after the gesture is detected the wallet is switched (which is also not very obvious if they have similar names). It also interfered with the Android system gestures (sometimes I would navigate back when I actually wanted to test wallet switching).

Since switching the wallet can now be done directly from the homescreen and I don't see a use case where users would switch back and forth all the time I don't see an immediate need for this other than being a gimmick / playful way to interact.

I'd put this on hold for now tbh.

@reneaaron reneaaron marked this pull request as draft February 26, 2025 14:39
@im-adithya
Copy link
Member Author

there is no user feedback when they start swiping

I tried to move the wallet balance text along when the user swipes it, but that makes the code hard to even understand because there are lot of things in it (the wiggle animation, swipe animation and the balance refresh scroll coming in between if you scroll diagonally (since scroll view catches any kind of downward swipe)

I don't see an immediate need for this other than being a gimmick / playful way to interact

I agree, the recent wallet switching change from the Home screen is already convenient enough 👍

@im-adithya
Copy link
Member Author

I also have another idea where we can show a ChevronDown icon beside the wallet name which opens a dropdown so the user can switch. Just putting it here since I thought of this for #281 and the same component can be reused here (but still it is not reducing any clicks and is unnecessary)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swipe left-right to switch a wallet
3 participants