c++14 compat

Author: CamJN

src/argv.cpp

@@ -6,7 +6,7 @@
 
 namespace Getargv {
 
-Argv::Argv(ffi::ArgvResult &r) : ffi::ArgvResult(r) {}
+Argv::Argv(const ffi::ArgvResult &r) : ffi::ArgvResult(r) {}
 Argv::~Argv() { ffi::free_ArgvResult(this); }
 
 bool Argv::print() {

src/argvargc.cpp

@@ -6,7 +6,7 @@
 
 namespace Getargv {
 
-ArgvArgc::ArgvArgc(ffi::ArgvArgcResult &r) : ffi::ArgvArgcResult(r) {}
+ArgvArgc::ArgvArgc(const ffi::ArgvArgcResult &r) : ffi::ArgvArgcResult(r) {}
 ArgvArgc::~ArgvArgc() { ffi::free_ArgvArgcResult(this); }
 
 ptrdiff_t ArgvArgc::size() const { return argc; }

src/libgetargv++.hpp

@@ -21,8 +21,10 @@ struct Argv : protected ffi::ArgvResult {
                        bool nuls = false) noexcept(false);
   static std::string as_string(pid_t pid, unsigned int skip,
                                bool nuls) noexcept(false);
+#if defined(__cplusplus) && (__cplusplus == 201703L)
   Argv(Argv &r) = delete;
-  Argv(ffi::ArgvResult &r);
+#endif
+  Argv(const ffi::ArgvResult &r);
   ~Argv();
 
   char &operator[](const ptrdiff_t index) const;
@@ -39,8 +41,10 @@ struct ArgvArgc : protected ffi::ArgvArgcResult {
 
   static ArgvArgc as_array(pid_t pid) noexcept(false);
   static std::vector<std::string> as_string_array(pid_t pid) noexcept(false);
+#if defined(__cplusplus) && (__cplusplus == 201703L)
   ArgvArgc(ArgvArgc &r) = delete;
-  ArgvArgc(ffi::ArgvArgcResult &r);
+#endif
+  ArgvArgc(const ffi::ArgvArgcResult &r);
   ~ArgvArgc();
 
   char *&operator[](const ptrdiff_t index) const;//auto converts to std::string

src/main.cpp

@@ -21,8 +21,8 @@ int main(int argc, char *argv[]) {
   static_assert(std::contiguous_iterator<Argv::Iterator>);
   static_assert(std::contiguous_iterator<ArgvArgc::Iterator>);
 #else
-  static_assert(std::is_same<std::random_access_iterator_tag, Argv::Iterator::iterator_category>::value);
-  static_assert(std::is_same<std::random_access_iterator_tag, ArgvArgc::Iterator::iterator_category>::value);
+  static_assert(std::is_same<std::random_access_iterator_tag, Argv::Iterator::iterator_category>::value, "testing that Argv::Iterator is a random_access_iterator failed");
+  static_assert(std::is_same<std::random_access_iterator_tag, ArgvArgc::Iterator::iterator_category>::value, "testing that ArgvArgc::Iterator is a random_access_iterator failed");
 #endif
 
   Argv bytes = Argv::as_bytes(pid, skip, nuls);