fix: record payment condition

Author: keellyp

src/components/customers/CustomerInvoicesList.tsx

@@ -331,6 +331,7 @@ export const CustomerInvoicesList: FC<CustomerInvoicesListProps> = ({
               taxStatus,
               totalPaidAmountCents,
               totalDueAmountCents,
+              totalAmountCents,
             } = invoice
 
             const { disabledIssueCreditNoteButton, disabledIssueCreditNoteButtonLabel } =
@@ -378,9 +379,9 @@ export const CustomerInvoicesList: FC<CustomerInvoicesListProps> = ({
               ![InvoiceStatusTypeEnum.Draft, InvoiceStatusTypeEnum.Voided].includes(status) &&
               hasPermissions(['creditNotesCreate'])
             const canRecordPayment =
-              totalDueAmountCents > 0 &&
+              Number(totalDueAmountCents) > 0 &&
               hasPermissions(['paymentsCreate']) &&
-              totalPaidAmountCents < totalDueAmountCents
+              Number(totalPaidAmountCents) < Number(totalAmountCents)
 
             return [
               canDownload

src/components/invoices/InvoicesList.tsx

@@ -165,7 +165,14 @@ const InvoicesList = ({
             isLoading={isLoading}
             hasError={!!error}
             actionColumn={(invoice) => {
-              const { status, paymentStatus, voidable, totalDueAmountCents } = invoice
+              const {
+                status,
+                paymentStatus,
+                voidable,
+                totalDueAmountCents,
+                totalPaidAmountCents,
+                totalAmountCents,
+              } = invoice
 
               const { disabledIssueCreditNoteButton, disabledIssueCreditNoteButtonLabel } =
                 createCreditNoteForInvoiceButtonProps({
@@ -209,7 +216,10 @@ const InvoicesList = ({
               const canIssueCreditNote =
                 ![InvoiceStatusTypeEnum.Draft, InvoiceStatusTypeEnum.Voided].includes(status) &&
                 hasPermissions(['creditNotesCreate'])
-              const canRecordPayment = totalDueAmountCents > 0 && hasPermissions(['paymentsCreate'])
+              const canRecordPayment =
+                Number(totalDueAmountCents) > 0 &&
+                hasPermissions(['paymentsCreate']) &&
+                Number(totalPaidAmountCents) < Number(totalAmountCents)
 
               return [
                 canDownload

src/pages/CustomerInvoiceDetails.tsx

@@ -98,8 +98,6 @@ import InvoiceOverview from '~/pages/InvoiceOverview'
 import ErrorImage from '~/public/images/maneki/error.svg'
 import { MenuPopper, PageHeader, theme } from '~/styles'
 
-import { useOrganizationInfos } from '../hooks/useOrganizationInfos'
-
 gql`
   fragment AllInvoiceDetailsForCustomerInvoiceDetails on Invoice {
     id
@@ -282,13 +280,13 @@ const CustomerInvoiceDetails = () => {
   const { goBack } = useLocationHistory()
   const { isPremium } = useCurrentUser()
   const { hasPermissions } = usePermissions()
-  const { organization: { premiumIntegrations } = {} } = useOrganizationInfos()
   const finalizeInvoiceRef = useRef<FinalizeInvoiceDialogRef>(null)
   const premiumWarningDialogRef = useRef<PremiumWarningDialogRef>(null)
   const updateInvoicePaymentStatusDialog = useRef<UpdateInvoicePaymentStatusDialogRef>(null)
   const addMetadataDrawerDialogRef = useRef<AddMetadataDrawerRef>(null)
   const voidInvoiceDialogRef = useRef<VoidInvoiceDialogRef>(null)
   const disputeInvoiceDialogRef = useRef<DisputeInvoiceDialogRef>(null)
+
   const [refreshInvoice, { loading: loadingRefreshInvoice }] = useRefreshInvoiceMutation({
     variables: { input: { id: invoiceId || '' } },
     context: {
@@ -437,6 +435,7 @@ const CustomerInvoiceDetails = () => {
     number,
     paymentStatus,
     totalAmountCents,
+    totalPaidAmountCents,
     totalDueAmountCents,
     currency,
     status,
@@ -449,6 +448,11 @@ const CustomerInvoiceDetails = () => {
     associatedActiveWalletPresent,
   } = (data?.invoice as AllInvoiceDetailsForCustomerInvoiceDetailsFragment) || {}
 
+  const canRecordPayment =
+    Number(totalDueAmountCents) > 0 &&
+    hasPermissions(['paymentsCreate']) &&
+    Number(totalPaidAmountCents) < Number(totalAmountCents)
+
   const hasError = (!!error || !data?.invoice) && !loading
   const hasTaxProviderError = errorDetails?.find(
     ({ errorCode }) => errorCode === ErrorCodesEnum.TaxError,
@@ -732,7 +736,7 @@ const CustomerInvoiceDetails = () => {
                         )}
                     </>
                   ) : null}
-                  {totalDueAmountCents > 0 && hasPermissions(['paymentsCreate']) && (
+                  {canRecordPayment && (
                     <Button
                       variant="quaternary"
                       align="left"