Skip to content

Commit a098d9e

Browse files
fix(spans): Fix incorrect MRIs for LCP and CLS span metrics (#4504)
Span metrics for LCP and CLS should have been written to `"d:transactions/measurements.cls@none"` and `"d:transactions/measurements.lcp@millisecond"`. This change corrects the MRIs. #skip-changelog
1 parent d893c21 commit a098d9e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

relay-dynamic-config/src/defaults.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1050,7 +1050,7 @@ pub fn hardcoded_span_metrics() -> Vec<(GroupKey, Vec<MetricSpec>, Vec<TagMappin
10501050
},
10511051
MetricSpec {
10521052
category: DataCategory::Span,
1053-
mri: "d:transactions/measurements.cls@ratio".into(),
1053+
mri: "d:transactions/measurements.cls@none".into(),
10541054
field: Some("span.measurements.cls.value".into()),
10551055
condition: Some(is_allowed_browser.clone()),
10561056
tags: vec![
@@ -1128,7 +1128,7 @@ pub fn hardcoded_span_metrics() -> Vec<(GroupKey, Vec<MetricSpec>, Vec<TagMappin
11281128
},
11291129
MetricSpec {
11301130
category: DataCategory::Span,
1131-
mri: "d:transactions/measurements.lcp@ratio".into(),
1131+
mri: "d:transactions/measurements.lcp@millisecond".into(),
11321132
field: Some("span.measurements.lcp.value".into()),
11331133
condition: Some(is_allowed_browser.clone()),
11341134
tags: vec![

relay-server/src/metrics_extraction/event.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1812,7 +1812,7 @@ mod tests {
18121812
);
18131813

18141814
for mri in [
1815-
"d:transactions/measurements.cls@ratio",
1815+
"d:transactions/measurements.cls@none",
18161816
"d:transactions/measurements.score.cls@ratio",
18171817
"d:transactions/measurements.score.total@ratio",
18181818
"d:transactions/measurements.score.weight.cls@ratio",
@@ -1852,7 +1852,7 @@ mod tests {
18521852
);
18531853

18541854
for mri in [
1855-
"d:transactions/measurements.lcp@ratio",
1855+
"d:transactions/measurements.lcp@millisecond",
18561856
"d:transactions/measurements.score.lcp@ratio",
18571857
"d:transactions/measurements.score.total@ratio",
18581858
"d:transactions/measurements.score.weight.lcp@ratio",

0 commit comments

Comments
 (0)