-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Spotlight without sending to Sentry #3481
Comments
Thanks for the feedback! I'll have to see what the other SDKs are up to.
I can see the being read in a way that you would not expect the events to have to go to Sentry. |
From what it looks like we should update the SDK to check for |
Does spotlight currently work for native events (crashes)? If so, that would also need to be taken into account. |
AFAIK, it currently does not, no. Oh no, that adds another layer.. |
It took me a bit to set Spotlight up in our .net projects due to the different DSN behavior compared to the JS sdk I set up first. It was also a huge surprise today to realize everything our .net code has logged to Spotlight is now also in Sentry 😕 |
@BYK cc Should we just not send to Sentry if Spotlight is set? |
Definitely not. The solution proposal in the ticket description is spot on:
I'm trying to come up with a final list of requirements here: getsentry/spotlight#545 |
Problem Statement
One of the first lines on the Spotlight about page is
The blogpost about the dotnet v4 SDK also says
However this does not seem to be possible, since the SDK will not initialise Sentry without a valid DSN and wil not send anything to Spotlight.
Solution Brainstorm
Requested: when
EnableSpotlight = true
is passed toSentrySdk.Init
, Sentry is always initialized even if there is no DSN.Optional: when Spotlight is enabled, ignore transaction sample rate setting and send everything to Sentry, while still using the configured rate to send to Sentry.
I did not test if the requested behaviour is present in other SDKs, except for the in-browser JS SDK. That one requires a separate
Spotlight.init()
call outside ofSentry.init
and does work without a DSN. For the other SDKs, Spotlight is turned on insideSentry.init
so might also ignore Spotlight if there is no DSN.The text was updated successfully, but these errors were encountered: