Skip to content

Commit 138417b

Browse files
authored
test(feedback): Fixes lazy loaded feedback bundles (#14410)
Include `handleLazyLoadedFeedback:true` when calling `getLocalTestUrl` for browser-integration-tests
1 parent 26f9db8 commit 138417b

File tree

8 files changed

+8
-8
lines changed
  • dev-packages/browser-integration-tests/suites

8 files changed

+8
-8
lines changed

dev-packages/browser-integration-tests/suites/feedback/attachTo/test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ sentryTest('should capture feedback with custom button', async ({ getLocalTestUr
2323
}
2424
});
2525

26-
const url = await getLocalTestUrl({ testDir: __dirname });
26+
const url = await getLocalTestUrl({ testDir: __dirname, handleLazyLoadedFeedback: true });
2727

2828
await page.goto(url);
2929
await page.locator('#custom-feedback-button').click();

dev-packages/browser-integration-tests/suites/feedback/captureFeedback/test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ sentryTest('should capture feedback', async ({ getLocalTestUrl, page }) => {
2323
}
2424
});
2525

26-
const url = await getLocalTestUrl({ testDir: __dirname });
26+
const url = await getLocalTestUrl({ testDir: __dirname, handleLazyLoadedFeedback: true });
2727

2828
await page.goto(url);
2929
await page.getByText('Report a Bug').click();

dev-packages/browser-integration-tests/suites/feedback/captureFeedbackAndReplay/hasSampling/test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ sentryTest('should capture feedback', async ({ forceFlushReplay, getLocalTestUrl
3131
}
3232
});
3333

34-
const url = await getLocalTestUrl({ testDir: __dirname });
34+
const url = await getLocalTestUrl({ testDir: __dirname, handleLazyLoadedFeedback: true });
3535

3636
await Promise.all([page.goto(url), page.getByText('Report a Bug').click(), reqPromise0]);
3737

dev-packages/browser-integration-tests/suites/feedback/captureFeedbackCsp/test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ sentryTest('should capture feedback', async ({ getLocalTestUrl, page }) => {
2323
}
2424
});
2525

26-
const url = await getLocalTestUrl({ testDir: __dirname });
26+
const url = await getLocalTestUrl({ testDir: __dirname, handleLazyLoadedFeedback: true });
2727

2828
await page.goto(url);
2929
await page.getByText('Report a Bug').click();

dev-packages/browser-integration-tests/suites/integrations/lazyLoad/feedbackIntegration/test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { sentryTest } from '../../../../utils/fixtures';
55

66
sentryTest('it allows to lazy load the feedback integration', async ({ getLocalTestUrl, page }) => {
77
const bundle = process.env.PW_BUNDLE || '';
8-
const url = await getLocalTestUrl({ testDir: __dirname });
8+
const url = await getLocalTestUrl({ testDir: __dirname, handleLazyLoadedFeedback: true });
99

1010
await page.route(`https://browser.sentry-cdn.com/${SDK_VERSION}/feedback.min.js`, route => {
1111
return route.fulfill({

dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/navigation/test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ sentryTest(
316316
sentryTest.skip();
317317
}
318318

319-
const url = await getLocalTestUrl({ testDir: __dirname });
319+
const url = await getLocalTestUrl({ testDir: __dirname, handleLazyLoadedFeedback: true });
320320

321321
// ensure pageload transaction is finished
322322
await getFirstSentryEnvelopeRequest<Event>(page, url);

dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/pageload-meta/test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ sentryTest('user feedback event after pageload has pageload traceId in headers',
302302
sentryTest.skip();
303303
}
304304

305-
const url = await getLocalTestUrl({ testDir: __dirname });
305+
const url = await getLocalTestUrl({ testDir: __dirname, handleLazyLoadedFeedback: true });
306306

307307
const pageloadEvent = await getFirstSentryEnvelopeRequest<Event>(page, url);
308308
const pageloadTraceContext = pageloadEvent.contexts?.trace;

dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/pageload/test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@ sentryTest('user feedback event after pageload has pageload traceId in headers',
442442
sentryTest.skip();
443443
}
444444

445-
const url = await getLocalTestUrl({ testDir: __dirname });
445+
const url = await getLocalTestUrl({ testDir: __dirname, handleLazyLoadedFeedback: true });
446446

447447
const pageloadEvent = await getFirstSentryEnvelopeRequest<Event>(page, url);
448448
const pageloadTraceContext = pageloadEvent.contexts?.trace;

0 commit comments

Comments
 (0)