Skip to content

Commit 3a53dd2

Browse files
authored
ref: Mangle more internal names (#2036)
* ref: Mangle more internal names * fix: Linter
1 parent d0ae28e commit 3a53dd2

File tree

10 files changed

+128
-121
lines changed

10 files changed

+128
-121
lines changed

.prettierignore

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
*.md

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
## Unreleased
4+
5+
- [browser] ref: Mangle more stuff, reduce bundle size
6+
37
## 5.1.1
48

59
- [browser] fix: Breadcrumb Integration: Fix #2034

packages/browser/src/backend.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
} from '@sentry/utils';
1313

1414
import { eventFromPlainObject, eventFromStacktrace, prepareFramesForEvent } from './parsers';
15-
import { computeStackTrace } from './tracekit';
15+
import { _computeStackTrace } from './tracekit';
1616
import { FetchTransport, XHRTransport } from './transports';
1717

1818
/**
@@ -72,7 +72,7 @@ export class BrowserBackend extends BaseBackend<BrowserOptions> {
7272
// If it is an ErrorEvent with `error` property, extract it to get actual Error
7373
const errorEvent = exception as ErrorEvent;
7474
exception = errorEvent.error; // tslint:disable-line:no-parameter-reassignment
75-
event = eventFromStacktrace(computeStackTrace(exception as Error));
75+
event = eventFromStacktrace(_computeStackTrace(exception as Error));
7676
return SyncPromise.resolve(this._buildEvent(event, hint));
7777
}
7878
if (isDOMError(exception as DOMError) || isDOMException(exception as DOMException)) {
@@ -91,7 +91,7 @@ export class BrowserBackend extends BaseBackend<BrowserOptions> {
9191
}
9292
if (isError(exception as Error)) {
9393
// we have a real Error object, do nothing
94-
event = eventFromStacktrace(computeStackTrace(exception as Error));
94+
event = eventFromStacktrace(_computeStackTrace(exception as Error));
9595
return SyncPromise.resolve(this._buildEvent(event, hint));
9696
}
9797
if (isPlainObject(exception as {}) && hint && hint.syntheticException) {
@@ -148,7 +148,7 @@ export class BrowserBackend extends BaseBackend<BrowserOptions> {
148148
};
149149

150150
if (this._options.attachStacktrace && hint && hint.syntheticException) {
151-
const stacktrace = computeStackTrace(hint.syntheticException);
151+
const stacktrace = _computeStackTrace(hint.syntheticException);
152152
const frames = prepareFramesForEvent(stacktrace.stack);
153153
event.stacktrace = {
154154
frames,

packages/browser/src/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ import * as Transports from './transports';
4040

4141
let windowIntegrations = {};
4242

43+
// This block is needed to add compatibility with the integrations packages when used with a CDN
4344
// tslint:disable: no-unsafe-any
4445
const _window = getGlobalObject<Window>() as any;
4546
if (_window.Sentry && _window.Sentry.Integrations) {

packages/browser/src/integrations/globalhandlers.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ import { addExceptionTypeValue, logger, normalize, truncate } from '@sentry/util
44

55
import { eventFromStacktrace } from '../parsers';
66
import {
7-
installGlobalHandler,
8-
installGlobalUnhandledRejectionHandler,
7+
_installGlobalHandler,
8+
_installGlobalUnhandledRejectionHandler,
9+
_subscribe,
910
StackTrace as TraceKitStackTrace,
10-
subscribe,
1111
} from '../tracekit';
1212

1313
import { shouldIgnoreOnError } from './helpers';
@@ -47,7 +47,7 @@ export class GlobalHandlers implements Integration {
4747
public setupOnce(): void {
4848
Error.stackTraceLimit = 50;
4949

50-
subscribe((stack: TraceKitStackTrace, _: boolean, error: Error) => {
50+
_subscribe((stack: TraceKitStackTrace, _: boolean, error: Error) => {
5151
// TODO: use stack.context to get a valuable information from TraceKit, eg.
5252
// [
5353
// 0: " })"
@@ -76,12 +76,12 @@ export class GlobalHandlers implements Integration {
7676

7777
if (this._options.onerror) {
7878
logger.log('Global Handler attached: onerror');
79-
installGlobalHandler();
79+
_installGlobalHandler();
8080
}
8181

8282
if (this._options.onunhandledrejection) {
8383
logger.log('Global Handler attached: onunhandledrejection');
84-
installGlobalUnhandledRejectionHandler();
84+
_installGlobalUnhandledRejectionHandler();
8585
}
8686
}
8787

packages/browser/src/integrations/linkederrors.ts

+7-7
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { addGlobalEventProcessor, getCurrentHub } from '@sentry/core';
22
import { Event, EventHint, Exception, ExtendedError, Integration } from '@sentry/types';
33

44
import { exceptionFromStacktrace } from '../parsers';
5-
import { computeStackTrace } from '../tracekit';
5+
import { _computeStackTrace } from '../tracekit';
66

77
const DEFAULT_KEY = 'cause';
88
const DEFAULT_LIMIT = 5;
@@ -44,7 +44,7 @@ export class LinkedErrors implements Integration {
4444
addGlobalEventProcessor((event: Event, hint?: EventHint) => {
4545
const self = getCurrentHub().getIntegration(LinkedErrors);
4646
if (self) {
47-
return self.handler(event, hint);
47+
return self._handler(event, hint);
4848
}
4949
return event;
5050
});
@@ -53,24 +53,24 @@ export class LinkedErrors implements Integration {
5353
/**
5454
* @inheritDoc
5555
*/
56-
public handler(event: Event, hint?: EventHint): Event | null {
56+
private _handler(event: Event, hint?: EventHint): Event | null {
5757
if (!event.exception || !event.exception.values || !hint || !(hint.originalException instanceof Error)) {
5858
return event;
5959
}
60-
const linkedErrors = this.walkErrorTree(hint.originalException, this._key);
60+
const linkedErrors = this._walkErrorTree(hint.originalException, this._key);
6161
event.exception.values = [...linkedErrors, ...event.exception.values];
6262
return event;
6363
}
6464

6565
/**
6666
* @inheritDoc
6767
*/
68-
public walkErrorTree(error: ExtendedError, key: string, stack: Exception[] = []): Exception[] {
68+
private _walkErrorTree(error: ExtendedError, key: string, stack: Exception[] = []): Exception[] {
6969
if (!(error[key] instanceof Error) || stack.length + 1 >= this._limit) {
7070
return stack;
7171
}
72-
const stacktrace = computeStackTrace(error[key]);
72+
const stacktrace = _computeStackTrace(error[key]);
7373
const exception = exceptionFromStacktrace(stacktrace);
74-
return this.walkErrorTree(error[key], key, [exception, ...stack]);
74+
return this._walkErrorTree(error[key], key, [exception, ...stack]);
7575
}
7676
}

packages/browser/src/parsers.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Event, Exception, StackFrame } from '@sentry/types';
22
import { keysToEventMessage, normalizeToSize } from '@sentry/utils';
33

4-
import { computeStackTrace, StackFrame as TraceKitStackFrame, StackTrace as TraceKitStackTrace } from './tracekit';
4+
import { _computeStackTrace, StackFrame as TraceKitStackFrame, StackTrace as TraceKitStackTrace } from './tracekit';
55

66
const STACKTRACE_LIMIT = 50;
77

@@ -43,7 +43,7 @@ export function eventFromPlainObject(exception: {}, syntheticException: Error |
4343
};
4444

4545
if (syntheticException) {
46-
const stacktrace = computeStackTrace(syntheticException);
46+
const stacktrace = _computeStackTrace(syntheticException);
4747
const frames = prepareFramesForEvent(stacktrace.stack);
4848
event.stacktrace = {
4949
frames,

0 commit comments

Comments
 (0)