Skip to content

Commit 57bf5c3

Browse files
authored
chore(replay): Cleanup package.json scripts (#6348)
Clean up the replay integration's `package.json` by getting rid of a few ToDos, enabling the circular dependency check and using the eslint cache of the monorepo. Since the future of the demo app in the replay package is still unclear, I opted to repurpose and rename the `bootstrap` script so that it now only bootstraps the demo app. For the package itself, bootstrapping happens via a monorepo-level `yarn` command or `lerna bootstrap` command.
1 parent 15b344f commit 57bf5c3

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

packages/replay/package.json

+4-6
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
"types": "build/npm/types/src/index.d.ts",
88
"sideEffects": false,
99
"scripts": {
10-
"bootstrap": "yarn && cd demo && yarn #TODO: change after migration",
1110
"build:rollup": "run-s build:worker build:core",
1211
"build": "run-s build:worker && run-p build:core build:types",
1312
"build:dev": "run-s build #TODO adjust after adding CDN bundles",
@@ -18,19 +17,18 @@
1817
"build:dev:watch": "yarn build:watch #TODO adjust after adding CDN bundles",
1918
"build:types:watch": "tsc -p tsconfig.types.json --watch",
2019
"build:npm": "ts-node ../../scripts/prepack.ts --bundles && npm pack ./build/npm",
21-
"circularDepCheck": "#TODO comment in after migration: madge --circular src/index.ts",
20+
"circularDepCheck": "madge --circular src/index.ts",
2221
"clean": "rimraf build sentry-replay-*.tgz",
2322
"fix": "run-s fix:eslint fix:prettier",
2423
"fix:eslint": "eslint . --format stylish --fix",
2524
"fix:prettier": "prettier --write \"{src,test,scripts,worker}/**/*.ts\"",
2625
"lint": "run-s lint:prettier lint:eslint",
27-
"lint:eslint": "eslint . --format stylish #TODO: we might want to use eslintcache after migration",
26+
"lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
2827
"lint:prettier": "prettier --check \"{src,test,scripts,worker}/**/*.ts\"",
2928
"test": "jest",
3029
"test:watch": "jest --watch",
31-
"start:demo": "yarn build:dev && cd demo && yarn start",
32-
"build:prod": "yarn build #TODO remove, we don't need this anymore after migration",
33-
"dev": "yarn build:dev:watch #TODO remove, we don't need this anymore after migration"
30+
"bootstrap:demo": "cd demo && yarn",
31+
"start:demo": "yarn build:dev && cd demo && yarn start"
3432
},
3533
"repository": {
3634
"type": "git",

0 commit comments

Comments
 (0)