Skip to content

Commit 6281d6b

Browse files
authored
feat(react-router): Filter manifest requests (#16294)
- Adds a regex for `GET /__manifest` requests to to the low quality tx filter - Moves the integration into the integration folder
1 parent 8295f1d commit 6281d6b

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

packages/react-router/src/server/lowQualityTransactionsFilterIntegration.ts renamed to packages/react-router/src/server/integration/lowQualityTransactionsFilterIntegration.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ function _lowQualityTransactionsFilterIntegration(options: NodeOptions): {
1010
name: string;
1111
processEvent: (event: Event, hint: EventHint, client: Client) => Event | null;
1212
} {
13-
const matchedRegexes = [/GET \/node_modules\//, /GET \/favicon\.ico/, /GET \/@id\//];
13+
const matchedRegexes = [/GET \/node_modules\//, /GET \/favicon\.ico/, /GET \/@id\//, /GET \/__manifest\?/];
1414

1515
return {
1616
name: 'LowQualityTransactionsFilter',

packages/react-router/src/server/sdk.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import type { NodeClient, NodeOptions } from '@sentry/node';
55
import { getDefaultIntegrations as getNodeDefaultIntegrations, init as initNodeSdk } from '@sentry/node';
66
import { DEBUG_BUILD } from '../common/debug-build';
77
import { SEMANTIC_ATTRIBUTE_SENTRY_OVERWRITE } from './instrumentation/util';
8+
import { lowQualityTransactionsFilterIntegration } from './integration/lowQualityTransactionsFilterIntegration';
89
import { reactRouterServerIntegration } from './integration/reactRouterServer';
9-
import { lowQualityTransactionsFilterIntegration } from './lowQualityTransactionsFilterIntegration';
1010

1111
/**
1212
* Returns the default integrations for the React Router SDK.

packages/react-router/test/server/lowQualityTransactionsFilterIntegration.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import type { Event, EventType, Integration } from '@sentry/core';
22
import * as SentryCore from '@sentry/core';
33
import * as SentryNode from '@sentry/node';
44
import { afterEach, describe, expect, it, vi } from 'vitest';
5-
import { lowQualityTransactionsFilterIntegration } from '../../src/server/lowQualityTransactionsFilterIntegration';
5+
import { lowQualityTransactionsFilterIntegration } from '../../src/server/integration/lowQualityTransactionsFilterIntegration';
66

77
const loggerLog = vi.spyOn(SentryCore.logger, 'log').mockImplementation(() => {});
88

@@ -18,6 +18,7 @@ describe('Low Quality Transactions Filter Integration', () => {
1818
['node_modules requests', 'GET /node_modules/some-package/index.js'],
1919
['favicon.ico requests', 'GET /favicon.ico'],
2020
['@id/ requests', 'GET /@id/some-id'],
21+
['manifest requests', 'GET /__manifest?p=%2Fperformance%2Fserver-action'],
2122
])('%s', (description, transaction) => {
2223
const integration = lowQualityTransactionsFilterIntegration({ debug: true }) as Integration;
2324
const event = {

packages/react-router/test/server/sdk.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import type { NodeClient } from '@sentry/node';
33
import * as SentryNode from '@sentry/node';
44
import { SDK_VERSION } from '@sentry/node';
55
import { afterEach, describe, expect, it, vi } from 'vitest';
6-
import * as LowQualityModule from '../../src/server/lowQualityTransactionsFilterIntegration';
6+
import * as LowQualityModule from '../../src/server/integration/lowQualityTransactionsFilterIntegration';
77
import { init as reactRouterInit } from '../../src/server/sdk';
88

99
const nodeInit = vi.spyOn(SentryNode, 'init');

0 commit comments

Comments
 (0)