review suggestions

Author: s1gr1d

packages/nuxt/src/common/types.ts

@@ -118,12 +118,12 @@ export type SentryNuxtModuleOptions = {
   dynamicImportForServerEntry?: boolean;
 
   /**
-   * By default—unless you configure `dynamicImportForServerEntry: false`—the SDK will try to wrap your application entrypoint
+   * By default—unless you configure `dynamicImportForServerEntry: false`—the SDK will try to wrap your Nitro server entrypoint
    * with a dynamic `import()` to ensure all dependencies can be properly instrumented. Any previous exports from the entrypoint are still exported.
    * Most exports of the server entrypoint are serverless functions and those are wrapped by Sentry. Other exports stay as-is.
    *
    * By default, the SDK will wrap the default export as well as a `handler` or `server` export from the entrypoint.
-   * If your application has a different main export that is used to run the application, you can overwrite this by providing an array of export names to wrap.
+   * If your server has a different main export that is used to run the server, you can overwrite this by providing an array of export names to wrap.
    * Any wrapped export is expected to be an async function.
    *
    * @default ['default', 'handler', 'server']

packages/nuxt/src/vite/utils.ts

@@ -66,6 +66,7 @@ export function extractFunctionReexportQueryParameters(query: string): { wrap: s
       ? wrapMatch[1]
           .split(',')
           .filter(param => param !== '')
+          // Sanitize, as code could be injected with another rollup plugin
           .map((str: string) => str.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'))
       : [];
 
@@ -74,6 +75,7 @@ export function extractFunctionReexportQueryParameters(query: string): { wrap: s
       ? reexportMatch[1]
           .split(',')
           .filter(param => param !== '' && param !== 'default')
+          // Sanitize, as code could be injected with another rollup plugin
           .map((str: string) => str.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'))
       : [];
 
@@ -108,7 +110,7 @@ export function constructWrappedFunctionExportQuery(
     consoleSandbox(() =>
       // eslint-disable-next-line no-console
       console.warn(
-        "[Sentry] No functions found to wrap. In case your server needs to export async functions other than `handler` or  `server`, consider adding the name(s) to Sentry's build options `sentry.entrypointWrappedFunctions` in your `nuxt.config.ts`.",
+        "[Sentry] No functions found to wrap. In case the server needs to export async functions other than `handler` or  `server`, consider adding the name(s) to Sentry's build options `sentry.entrypointWrappedFunctions` in `nuxt.config.ts`.",
       ),
     );
   }
@@ -120,7 +122,7 @@ export function constructWrappedFunctionExportQuery(
     ? `${SENTRY_REEXPORTED_FUNCTIONS}${functionsToExport.reexport.join(',')}`
     : '';
 
-  return [wrapQuery, reexportQuery].filter(Boolean).join('');
+  return [wrapQuery, reexportQuery].join('');
 }
 
 /**

packages/nuxt/test/vite/utils.test.ts

@@ -152,7 +152,7 @@ describe('constructWrappedFunctionExportQuery', () => {
     const result = constructWrappedFunctionExportQuery(exportedBindings, entrypointWrappedFunctions, debug);
     expect(result).toBe('?sentry-query-reexported-functions=handler');
     expect(consoleWarnSpy).toHaveBeenCalledWith(
-      "[Sentry] No functions found to wrap. In case your server needs to export async functions other than `handler` or  `server`, consider adding the name(s) to Sentry's build options `sentry.entrypointWrappedFunctions` in your `nuxt.config.ts`.",
+      "[Sentry] No functions found to wrap. In case the server needs to export async functions other than `handler` or  `server`, consider adding the name(s) to Sentry's build options `sentry.entrypointWrappedFunctions` in `nuxt.config.ts`.",
     );
 
     consoleWarnSpy.mockRestore();