Skip to content

Commit 62fdfe7

Browse files
chargomemydea
andauthored
ci: Update labels for remix integration tests (#15076)
- Updates the label for remix integration tests. - Updates client types for captureRemixServerException params Follow up to #14988 --------- Co-authored-by: Francesco Gringl-Novy <[email protected]>
1 parent 2dc9d87 commit 62fdfe7

File tree

3 files changed

+3
-13
lines changed

3 files changed

+3
-13
lines changed

.github/workflows/build.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -747,7 +747,7 @@ jobs:
747747
run: yarn test
748748

749749
job_remix_integration_tests:
750-
name: Remix v${{ matrix.remix }} (Node ${{ matrix.node }}) Tests
750+
name: Remix (Node ${{ matrix.node }}) Tests
751751
needs: [job_get_metadata, job_build]
752752
if: needs.job_build.outputs.changed_remix == 'true' || github.event_name != 'pull_request'
753753
runs-on: ubuntu-20.04

packages/remix/src/index.client.tsx

+1-6
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,7 @@ export * from '@sentry/react';
1515
// function signature is the same as in the server SDK.
1616
// See issue: https://github.com/getsentry/sentry-javascript/issues/9594
1717
/* eslint-disable @typescript-eslint/no-unused-vars */
18-
export async function captureRemixServerException(
19-
err: unknown,
20-
name: string,
21-
request: Request,
22-
isRemixV2?: boolean,
23-
): Promise<void> {
18+
export async function captureRemixServerException(err: unknown, name: string, request: Request): Promise<void> {
2419
DEBUG_BUILD &&
2520
logger.warn(
2621
'`captureRemixServerException` is a server-only function and should not be called in the browser. ' +

packages/remix/src/index.types.ts

+1-6
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,7 @@ export declare const contextLinesIntegration: typeof clientSdk.contextLinesInteg
1818
export declare const getDefaultIntegrations: (options: Options) => Integration[];
1919
export declare const defaultStackParser: StackParser;
2020

21-
export declare function captureRemixServerException(
22-
err: unknown,
23-
name: string,
24-
request: Request,
25-
isRemixV2?: boolean,
26-
): Promise<void>;
21+
export declare function captureRemixServerException(err: unknown, name: string, request: Request): Promise<void>;
2722

2823
// This variable is not a runtime variable but just a type to tell typescript that the methods below can either come
2924
// from the client SDK or from the server SDK. TypeScript is smart enough to understand that these resolve to the same

0 commit comments

Comments
 (0)