Skip to content

Commit 8218578

Browse files
authored
feat(ember): Use @types/ember__debug (#4173)
No need to roll a version of this module when a better one is available. This has the added benefit of allowing `assert` to assert the `test` param. Will address Ember 4 (and the auto import changes) in another PR.
1 parent a72ea44 commit 8218578

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

packages/ember/addon/index.ts

-4
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@ import { timestampWithMs } from '@sentry/utils';
88
import { GlobalConfig, OwnConfig } from './types';
99
import { getGlobalObject } from '@sentry/utils';
1010

11-
declare module '@ember/debug' {
12-
export function assert(desc: string, test: unknown): void;
13-
}
14-
1511
function _getSentryInitConfig() {
1612
const _global = getGlobalObject<GlobalConfig>();
1713
_global.__sentryEmberConfig = _global.__sentryEmberConfig ?? {};

packages/ember/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
"@sentry-internal/eslint-config-sdk": "6.15.0",
5050
"@types/ember": "~3.16.5",
5151
"@types/ember-qunit": "~3.4.9",
52+
"@types/ember__debug": "^3.16.5",
5253
"@types/ember__test-helpers": "~1.7.0",
5354
"@types/qunit": "~2.9.1",
5455
"@types/rsvp": "~4.0.3",

yarn.lock

+9
Original file line numberDiff line numberDiff line change
@@ -3145,6 +3145,15 @@
31453145
"@types/ember__engine" "*"
31463146
"@types/ember__object" "*"
31473147

3148+
"@types/ember__debug@^3.16.5":
3149+
version "3.16.5"
3150+
resolved "https://registry.yarnpkg.com/@types/ember__debug/-/ember__debug-3.16.5.tgz#ce04532c100fdc1c97c9f308d69a88d6e956db97"
3151+
integrity sha512-Sj0idBMOd33PubBbxtXty+tzyVIAbxK4cf8q0AKZ0z5wOL0wsFOLCvMgRMxSME3DB2uvJd4u9tGr15XFM+Z03A==
3152+
dependencies:
3153+
"@types/ember__debug" "*"
3154+
"@types/ember__engine" "*"
3155+
"@types/ember__object" "*"
3156+
31483157
"@types/ember__destroyable@*":
31493158
version "3.22.0"
31503159
resolved "https://registry.yarnpkg.com/@types/ember__destroyable/-/ember__destroyable-3.22.0.tgz#2af2c27f5d8996694c3f0fe906e2536b2e4c5aca"

0 commit comments

Comments
 (0)