feat(core)!: Add normalizedRequest to samplingContext (#14902)

The sampling context didn't include the `request` object anymore. By
adding the `normalizedRequest`, this data is added again.

Author: s1gr1d

dev-packages/node-integration-tests/suites/express/tracing/tracesSampler/scenario-normalizedRequest.js

@@ -0,0 +1,34 @@
+const { loggingTransport } = require('@sentry-internal/node-integration-tests');
+const Sentry = require('@sentry/node');
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+  release: '1.0',
+  transport: loggingTransport,
+  tracesSampler: samplingContext => {
+    // The sampling decision is based on whether the data in `normalizedRequest` is available --> this is what we want to test for
+    return (
+      samplingContext.normalizedRequest.url.includes('/test-normalized-request?query=123') &&
+      samplingContext.normalizedRequest.method &&
+      samplingContext.normalizedRequest.query_string === 'query=123' &&
+      !!samplingContext.normalizedRequest.headers
+    );
+  },
+});
+
+// express must be required after Sentry is initialized
+const express = require('express');
+const cors = require('cors');
+const { startExpressServerAndSendPortToRunner } = require('@sentry-internal/node-integration-tests');
+
+const app = express();
+
+app.use(cors());
+
+app.get('/test-normalized-request', (_req, res) => {
+  res.send('Success');
+});
+
+Sentry.setupExpressErrorHandler(app);
+
+startExpressServerAndSendPortToRunner(app);

dev-packages/node-integration-tests/suites/express/tracing/tracesSampler/server.js

@@ -15,7 +15,6 @@ Sentry.init({
       samplingContext.attributes['http.method'] === 'GET'
     );
   },
-  debug: true,
 });
 
 // express must be required after Sentry is initialized

dev-packages/node-integration-tests/suites/express/tracing/tracesSampler/test.ts

@@ -22,3 +22,23 @@ describe('express tracesSampler', () => {
     });
   });
 });
+
+describe('express tracesSampler includes normalizedRequest data', () => {
+  afterAll(() => {
+    cleanupChildProcesses();
+  });
+
+  describe('CJS', () => {
+    test('correctly samples & passes data to tracesSampler', done => {
+      const runner = createRunner(__dirname, 'scenario-normalizedRequest.js')
+        .expect({
+          transaction: {
+            transaction: 'GET /test-normalized-request',
+          },
+        })
+        .start(done);
+
+      runner.makeRequest('get', '/test-normalized-request?query=123');
+    });
+  });
+});

docs/migration/v8-to-v9.md

@@ -220,6 +220,7 @@ Since v9, the types have been merged into `@sentry/core`, which removed some of
 - The `TransactionNamingScheme` type has been removed. There is no replacement.
 - The `Request` type has been removed. Use `RequestEventData` type instead.
 - The `IntegrationClass` type is no longer exported - it was not used anymore. Instead, use `Integration` or `IntegrationFn`.
+- The `samplingContext.request` attribute in the `tracesSampler` has been removed. Use `samplingContext.normalizedRequest` instead. Note that the type of `normalizedRequest` differs from `request`.
 
 # No Version Support Timeline
 

packages/core/src/tracing/sampling.ts

@@ -1,5 +1,6 @@
 import type { Options, SamplingContext } from '../types-hoist';
 
+import { getIsolationScope } from '../currentScopes';
 import { DEBUG_BUILD } from '../debug-build';
 import { logger } from '../utils-hoist/logger';
 import { hasTracingEnabled } from '../utils/hasTracingEnabled';
@@ -20,13 +21,20 @@ export function sampleSpan(
     return [false];
   }
 
+  const normalizedRequest = getIsolationScope().getScopeData().sdkProcessingMetadata.normalizedRequest;
+
+  const enhancedSamplingContext = {
+    ...samplingContext,
+    normalizedRequest: samplingContext.normalizedRequest || normalizedRequest,
+  };
+
   // we would have bailed already if neither `tracesSampler` nor `tracesSampleRate` nor `enableTracing` were defined, so one of these should
   // work; prefer the hook if so
   let sampleRate;
   if (typeof options.tracesSampler === 'function') {
-    sampleRate = options.tracesSampler(samplingContext);
-  } else if (samplingContext.parentSampled !== undefined) {
-    sampleRate = samplingContext.parentSampled;
+    sampleRate = options.tracesSampler(enhancedSamplingContext);
+  } else if (enhancedSamplingContext.parentSampled !== undefined) {
+    sampleRate = enhancedSamplingContext.parentSampled;
   } else if (typeof options.tracesSampleRate !== 'undefined') {
     sampleRate = options.tracesSampleRate;
   } else {

packages/core/src/types-hoist/samplingcontext.ts

@@ -1,4 +1,5 @@
-import type { ExtractedNodeRequestData, WorkerLocation } from './misc';
+import type { RequestEventData } from '../types-hoist/request';
+import type { WorkerLocation } from './misc';
 import type { SpanAttributes } from './span';
 
 /**
@@ -35,9 +36,9 @@ export interface SamplingContext extends CustomSamplingContext {
   location?: WorkerLocation;
 
   /**
-   * Object representing the incoming request to a node server.
+   * Object representing the incoming request to a node server in a normalized format.
    */
-  request?: ExtractedNodeRequestData;
+  normalizedRequest?: RequestEventData;
 
   /** The name of the span being sampled. */
   name: string;