Skip to content

Commit bffbe8b

Browse files
authored
fix(v8/solidstart): Do not copy release-injection map file (#15304)
Backport of #15302
1 parent a474841 commit bffbe8b

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

packages/solidstart/src/config/addInstrumentation.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,9 @@ export async function addInstrumentationFileToBuild(nitro: Nitro): Promise<void>
4545
try {
4646
const ssrAssetsPath = path.resolve(buildDir, 'build', 'ssr', 'assets');
4747
const assetsBuildDir = await fs.promises.readdir(ssrAssetsPath);
48-
const releaseInjectionFile = assetsBuildDir.find(file => file.startsWith('_sentry-release-injection-file-'));
48+
const releaseInjectionFile = assetsBuildDir.find(file =>
49+
/^_sentry-release-injection-file-.*\.(js|mjs)$/.test(file),
50+
);
4951

5052
if (releaseInjectionFile) {
5153
const releaseSource = path.resolve(ssrAssetsPath, releaseInjectionFile);

packages/solidstart/test/config/addInstrumentation.test.ts

+17
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,23 @@ describe('addInstrumentationFileToBuild()', () => {
126126
expect(fsMkdirMock).not.toHaveBeenCalled();
127127
});
128128

129+
it('does not copy release injection file source map file', async () => {
130+
fsExistsSyncMock.mockReturnValue(true);
131+
fsReaddirMock.mockResolvedValueOnce(['_sentry-release-injection-file-test.js.map']);
132+
fsCopyFileMock.mockResolvedValueOnce(true);
133+
await addInstrumentationFileToBuild(nitroOptions);
134+
135+
await callNitroCloseHook();
136+
137+
expect(fsCopyFileMock).not.toHaveBeenCalledWith(
138+
'/path/to/buildDir/build/ssr/assets/_sentry-release-injection-file-test.js.map',
139+
'/path/to/serverDir/assets/_sentry-release-injection-file-test.js.map',
140+
);
141+
expect(consoleLogSpy).not.toHaveBeenCalledWith(
142+
'[Sentry SolidStart withSentry] Successfully created /path/to/serverDir/assets/_sentry-release-injection-file-test.js.map.',
143+
);
144+
});
145+
129146
it('copies release injection file if available', async () => {
130147
fsExistsSyncMock.mockReturnValue(true);
131148
fsReaddirMock.mockResolvedValueOnce(['_sentry-release-injection-file-test.js']);

0 commit comments

Comments
 (0)