You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This removes two `tsconfig` settings which don't have any effect given settings elsewhere in the repo:
- `noEmitHelpers`: The TS config docs[1] aren't super clear in saying this explicitly, but `noEmitHelpers` has no effect in the presence of `importHelpers: true`, because the latter means that no helper implementations will be emitted in any case, instead being imported from `tslib`.
- Node types: We've had Node types in our repo-level `tsconfig` for a long time, but all packages which need Node types already specify it themselves. Removing it in our top-level tsconfig also has the advantage that it means we won't accidentally use Node types where we shouldn't (like in browser-based and cross-platform packages).
[1] https://www.typescriptlang.org/tsconfig#noEmitHelpers
0 commit comments