Skip to content

Commit c072b89

Browse files
authored
chore(build): Remove redundant tsconfig settings (#5765)
This removes two `tsconfig` settings which don't have any effect given settings elsewhere in the repo: - `noEmitHelpers`: The TS config docs[1] aren't super clear in saying this explicitly, but `noEmitHelpers` has no effect in the presence of `importHelpers: true`, because the latter means that no helper implementations will be emitted in any case, instead being imported from `tslib`. - Node types: We've had Node types in our repo-level `tsconfig` for a long time, but all packages which need Node types already specify it themselves. Removing it in our top-level tsconfig also has the advantage that it means we won't accidentally use Node types where we shouldn't (like in browser-based and cross-platform packages). [1] https://www.typescriptlang.org/tsconfig#noEmitHelpers
1 parent 9862a32 commit c072b89

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

packages/typescript/tsconfig.json

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"isolatedModules": true,
1010
"lib": ["es6", "dom"],
1111
"moduleResolution": "node",
12-
"noEmitHelpers": true,
1312
"noErrorTruncation": true,
1413
"noFallthroughCasesInSwitch": true,
1514
"noImplicitReturns": true,

tsconfig.json

-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,5 @@
66
"declaration": false,
77
"declarationMap": false,
88
"skipLibCheck": true,
9-
"types": ["node"],
109
}
1110
}

0 commit comments

Comments
 (0)