Skip to content

Commit c0a29c3

Browse files
committed
Remove addSpanProcessor call
1 parent 370f263 commit c0a29c3

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

packages/core/src/utils/spanUtils.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ export function spanToJSON(span: Span): SpanJSON {
147147
// Handle a span from @opentelemetry/sdk-base-trace's `Span` class
148148
if (spanIsOpenTelemetrySdkTraceBaseSpan(span)) {
149149
const { attributes, startTime, name, endTime, status, links } = span;
150-
const parent_span_id = span.parentSpanContext?.spanId
150+
const parent_span_id = span.parentSpanContext?.spanId;
151151

152152
return dropUndefinedKeys({
153153
span_id,

packages/opentelemetry/test/helpers/createSpan.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type { SpanContext, TimeInput } from '@opentelemetry/api';
1+
import type { TimeInput } from '@opentelemetry/api';
22
import { context, trace, SpanKind } from '@opentelemetry/api';
33
import type { SpanProcessor } from '@opentelemetry/sdk-trace-node';
44
import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node';

packages/opentelemetry/test/utils/setupCheck.test.ts

+8-10
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node';
1+
import {NodeTracerProvider} from '@opentelemetry/sdk-trace-node';
22

3-
import { SentrySampler } from '../../src/sampler';
4-
import { SentrySpanProcessor } from '../../src/spanProcessor';
5-
import { openTelemetrySetupCheck } from '../../src/utils/setupCheck';
6-
import { TestClient, getDefaultTestClientOptions } from '../helpers/TestClient';
7-
import { setupOtel } from '../helpers/initOtel';
8-
import { cleanupOtel } from '../helpers/mockSdkInit';
3+
import {SentrySampler} from '../../src/sampler';
4+
import {SentrySpanProcessor} from '../../src/spanProcessor';
5+
import {openTelemetrySetupCheck} from '../../src/utils/setupCheck';
6+
import {TestClient, getDefaultTestClientOptions} from '../helpers/TestClient';
7+
import {setupOtel} from '../helpers/initOtel';
8+
import {cleanupOtel} from '../helpers/mockSdkInit';
99

1010
describe('openTelemetrySetupCheck', () => {
1111
let provider: NodeTracerProvider | undefined;
@@ -35,10 +35,8 @@ describe('openTelemetrySetupCheck', () => {
3535
const client = new TestClient(getDefaultTestClientOptions());
3636
provider = new NodeTracerProvider({
3737
sampler: new SentrySampler(client),
38+
spanProcessors: [new SentrySpanProcessor()],
3839
});
39-
// We want to test this deprecated case also works
40-
// eslint-disable-next-line deprecation/deprecation
41-
provider.addSpanProcessor(new SentrySpanProcessor());
4240

4341
const setup = openTelemetrySetupCheck();
4442
expect(setup).toEqual(['SentrySampler', 'SentrySpanProcessor']);

0 commit comments

Comments
 (0)