Skip to content

Commit d227ce0

Browse files
committed
fix stuff
1 parent fdefddd commit d227ce0

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

dev-packages/e2e-tests/test-applications/node-exports-test-app/scripts/consistentExports.ts

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ const NODE_EXPORTS_IGNORE = [
1818
'setNodeAsyncContextStrategy',
1919
'getDefaultIntegrationsWithoutPerformance',
2020
'initWithoutDefaultIntegrations',
21+
'preloadOpenTelemetry',
2122
];
2223

2324
const nodeExports = Object.keys(SentryNode).filter(e => !NODE_EXPORTS_IGNORE.includes(e));

dev-packages/node-integration-tests/suites/tracing/redis-cache/test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
22

3-
describe('redis auto instrumentation', () => {
3+
describe('redis cache auto instrumentation', () => {
44
afterAll(() => {
55
cleanupChildProcesses();
66
});

packages/node/src/integrations/http.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -163,11 +163,10 @@ export const instrumentHttp = Object.assign(
163163
);
164164

165165
const _httpIntegration = ((options: HttpOptions = {}) => {
166-
_httpOptions = options;
167-
168166
return {
169167
name: INTEGRATION_NAME,
170168
setupOnce() {
169+
_httpOptions = options;
171170
instrumentHttp();
172171
},
173172
};

packages/node/src/integrations/tracing/redis.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ export const instrumentRedis = generateInstrumentOnce(INTEGRATION_NAME, () => {
5050
responseHook: (span, redisCommand, cmdArgs, response) => {
5151
const key = cmdArgs[0];
5252

53+
console.log('AHA', JSON.stringify(_redisOptions));
54+
5355
span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, 'auto.db.otel.redis');
5456

5557
if (!_redisOptions?.cachePrefixes || !shouldConsiderForCache(redisCommand, key, _redisOptions.cachePrefixes)) {
@@ -90,11 +92,10 @@ export const instrumentRedis = generateInstrumentOnce(INTEGRATION_NAME, () => {
9092
});
9193

9294
const _redisIntegration = ((options: RedisOptions = {}) => {
93-
_redisOptions = options;
94-
9595
return {
9696
name: INTEGRATION_NAME,
9797
setupOnce() {
98+
_redisOptions = options;
9899
instrumentRedis();
99100

100101
// todo: implement them gradually

0 commit comments

Comments
 (0)