Skip to content

Commit d9d3b06

Browse files
authored
fix(aws-serverless): Remove v8 layer as it overwrites the current layer for docs (#14679)
Unfortunately, having the v8 layer already in `.craft.yml` ends up with this layer being the default selection in the docs. ![Screenshot 2024-12-12 at 13 02 08@2x](https://github.com/user-attachments/assets/30bb83ce-79e9-41b1-887b-ec4ab7019a10) We should add this to the `v8` branch once it exists instead.
1 parent 938fe65 commit d9d3b06

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

.craft.yml

+5-6
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,12 @@ targets:
142142
id: '@sentry-internal/eslint-config-sdk'
143143
includeNames: /^sentry-internal-eslint-config-sdk-\d.*\.tgz$/
144144

145-
# AWS Lambda Layer target
145+
# TODO(v9): Remove this target
146+
# NOTE: We publish the v8 layer under its own name so people on v8 can still get patches
147+
# whenever we release a new v8 version—otherwise we would overwrite the current major lambda layer.
146148
- name: aws-lambda-layer
147149
includeNames: /^sentry-node-serverless-\d+.\d+.\d+(-(beta|alpha|rc)\.\d+)?\.zip$/
148-
layerName: SentryNodeServerlessSDK
150+
layerName: SentryNodeServerlessSDKv8
149151
compatibleRuntimes:
150152
- name: node
151153
versions:
@@ -157,13 +159,10 @@ targets:
157159
- nodejs20.x
158160
license: MIT
159161

160-
# NOTE: We publish the v8 layer under its own name so people on v8 can still get patches
161-
# whenever we release a new v8 version—otherwise we would overwrite the current major lambda layer.
162-
163162
# AWS Lambda Layer target
164163
- name: aws-lambda-layer
165164
includeNames: /^sentry-node-serverless-\d+.\d+.\d+(-(beta|alpha|rc)\.\d+)?\.zip$/
166-
layerName: SentryNodeServerlessSDKv8
165+
layerName: SentryNodeServerlessSDK
167166
compatibleRuntimes:
168167
- name: node
169168
versions:

0 commit comments

Comments
 (0)