Skip to content

Commit da0cffe

Browse files
committed
fixes
1 parent ce66d26 commit da0cffe

File tree

4 files changed

+10
-11
lines changed

4 files changed

+10
-11
lines changed

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/navigation-redirect/click/init.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,3 @@ Sentry.init({
88
tracesSampleRate: 1,
99
debug: true,
1010
});
11-
12-
document.getElementById('btn1').addEventListener('click', () => {
13-
// trigger redirect immediately
14-
window.history.pushState({}, '', '/sub-page');
15-
});
16-
17-
// Now trigger click, whic should trigger navigation
18-
document.getElementById('btn1').click();
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
document.getElementById('btn1').addEventListener('click', () => {
2+
// trigger redirect immediately
3+
window.history.pushState({}, '', '/sub-page');
4+
});
5+
6+
// Now trigger click, which should trigger navigation
7+
document.getElementById('btn1').click();

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/navigation-redirect/click/template.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
<head>
44
<meta charset="utf-8" />
55
</head>
6-
<button id="btn1">Trigger navigation</button>
6+
<button id="btn1" type="button">Trigger navigation</button>
77
</html>

packages/browser/src/tracing/browserTracingIntegration.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -469,8 +469,8 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
469469
const clickHandler = (): void => {
470470
lastInteractionTimestamp = timestampInSeconds();
471471
};
472-
addEventListener('click', () => clickHandler, { capture: true, passive: true });
473-
addEventListener('keypress', () => clickHandler, { capture: true, passive: true });
472+
addEventListener('click', clickHandler, { capture: true });
473+
addEventListener('keydown', clickHandler, { capture: true, passive: true });
474474
}
475475

476476
function maybeEndActiveSpan(): void {

0 commit comments

Comments
 (0)