Skip to content

Commit edbb214

Browse files
authored
chore(deno): Stop testing types (#14738)
I noticed that after #14729, now tests started failing 😬 The reason: * We run `deno check ./build/index.mjs` * This checks the types, but we now do not inline those anymore into the generated `./build/index.d.ts` file * Instead, we just import them from `@sentry/core` * Now `deno check` downloads the latest version of core into a local tmp folder and uses this for checking * But there are different exports there than locally, leading to test failures 😬 this PR simple kills the type tests - not sure if we need them/they are needed, but I can't think of a different way to make this work, there isn't really a way (as far as I see?) to tell `deno check` to consider a dependency from a local path instead 😬
1 parent 748f643 commit edbb214

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

packages/deno/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,8 @@
4747
"prelint": "yarn deno-types",
4848
"lint": "eslint . --format stylish",
4949
"install:deno": "node ./scripts/install-deno.mjs",
50-
"pretest": "run-s deno-types",
51-
"test": "run-s install:deno test:types test:unit",
52-
"test:types": "deno check ./build/index.mjs",
53-
"test:unit": "deno test --allow-read --allow-run",
50+
"test": "run-s install:deno deno-types test:unit",
51+
"test:unit": "deno test --allow-read --allow-run --no-check",
5452
"test:unit:update": "deno test --allow-read --allow-write --allow-run -- --update",
5553
"yalc:publish": "node ./scripts/prepack.js && yalc publish build --push --sig"
5654
},

0 commit comments

Comments
 (0)