Skip to content

Allow ignoreErrors to take function instead of list of regexp/strings #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kamilogorek opened this issue Sep 27, 2017 · 5 comments
Closed

Comments

@kamilogorek
Copy link
Contributor

ref: #1057

@jaydp17
Copy link

jaydp17 commented Oct 4, 2017

There are 2 ways we can do this.

  1. Allow globalOptions.ignoreErrors to take regex/string as well as functions
  2. Add something like globalOptions.shouldIgnoreError which takes a function and returns a boolean

I'd prefer the 1st option but would like to know your opinion.

@kamilogorek
Copy link
Contributor Author

Agree that 1st option is more optimal. Please keep this comment in mind though #1057 (comment)

@HeroProtagonist
Copy link
Contributor

Hi,

Happy Hacktober! I will take a stab at this. PR to come in the next day or two.

Cheers!

@kamilogorek
Copy link
Contributor Author

@HeroProtagonist
Copy link
Contributor

@kamilogorek , Got it! I made a PR for #774 #1080. Hopefully it's good 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants