-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
W3C Trace Context support #11171
Comments
@stephanie-anderson @AbhiPrasad would you be open to a PR for this, along the lines of the PHP library support (getsentry/sentry-php#1680, getsentry/sentry-php#1713) using getsentry/team-sdks#41 (comment) to generate the traceparent value? I'd be happy to put something together |
Hi @jamescrowley thanks for offering to open a PR! At the moment we're still figuring out a somewhat related issue with trace propagation (more specifically, how to avoid propagating traces across multiple sentry orgs/customers). So we didn't move forward with implementing this. In JS (browser) specifically, we also can't hard-switch to |
@jamescrowley could you shed some light on your supposed use-case for the |
@cleptric we have an React SPA with no server-side rendering. We're looking to align the trace identifiers that Sentry generates on the client, with the server logs on the Google Cloud side. At the moment, server-side requests receive a conflicting traceparent from the Google infrastructure and a sentry-trace from the client-side request that has been intercepted by Sentry, but that's not something we can get the GCP side to use. Hope that makes sense, happy to explore further - or indeed if there are alternatives to achieving this. I had a look at hooking into the fetch interception logic on the Sentry client when you create the span ids and inject the sentry-trace header (addTracingHeadersToFetchRequest), but there doesn't appear to be a 'nice' point to do that. Given ^^ I'll look now at creating our own span when making web requests, and adding our own header using the logic outlined here getsentry/team-sdks#41 (comment) - which (not verified yet) but hopefully Sentry will then re-use the existing span for the request so the two match. |
Our main goal, if we add support for the |
getsentry/team-sdks#41
The text was updated successfully, but these errors were encountered: