-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Support Express v5 #13674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I would appreciate sentry supporting express v5. Having support here would help express finally get v5 released under the "latest" tag. 🙏 Sentry also integrates with GQL and I believe the |
is it suggested to use sentry for monitoring in production with express v5 (performance , profiling and error tracing ) ? |
@kvjoshi we are still waiting on open-telemetry/opentelemetry-js-contrib#2437, at the moment we don't have an ETA. You can subscribe to this issue to get notified when we have updates. |
Also, just one note here: You should be able to use Sentry with Express 5, you'll just lack a few performance-related data points: You will not have properly parametrized routes, as well as e.g. middleware spans will be lacking. Error monitoring and basic http-server tracing will still work, even now! |
A PR closing this issue has just been released 🚀This issue was referenced by PR #15380, which was included in the 9.2.0 release. |
Description
It seems that Express v5 is actually close: https://github.com/expressjs/express/releases/tag/v5.0.0
We should ensure we have support for this. This means ensuring that this is supported upstream in the OTEL instrumentation.
Current Status
As of now, you can use the Sentry SDK with Express v5, there is just limited support for some of the features:
[Sentry] express is not instrumented. Please make sure to initialize Sentry in a separate file that you --import when running node
. For the time being, you can silence this warning by configuringdisableInstrumentationWarnings: true
in yourinit({})
call.The text was updated successfully, but these errors were encountered: