Skip to content

Events can be added to buffer despite the session being expired #13855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
billyvg opened this issue Oct 2, 2024 · 1 comment
Closed

Events can be added to buffer despite the session being expired #13855

billyvg opened this issue Oct 2, 2024 · 1 comment
Assignees

Comments

@billyvg
Copy link
Member

billyvg commented Oct 2, 2024

Still investigating, but we are getting event buffer issues because expired sessions are not properly ending the session.
handleException is causing a possible infinite loop of sorts for expired sessions. it eventually ends up calling addEvent() which only checks if replay is paused or ended and not if session is valid. This causes a buildup in the buffer.

e.g. user idles on the page and replay continues to try to flush after the session has ended. Session is not ending properly so buffer continues to grow in size and continues to flush.

This also causes a replay with canvas recordings because resets will cause a new web worker to initialize leading to browser crashes

@billyvg billyvg changed the title Expired sessions are not resetting state properly Expired replay sessions are not resetting state properly Oct 2, 2024
@billyvg billyvg self-assigned this Oct 2, 2024
@billyvg billyvg changed the title Expired replay sessions are not resetting state properly Events can be added to buffer despite the session being expired Oct 2, 2024
@billyvg
Copy link
Member Author

billyvg commented Oct 24, 2024

This issue is not entirely accurate, but closed by #13962 which contains the actual problem

@billyvg billyvg closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant