Skip to content

Deprecate Nest usage in @sentry/node #14242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mydea opened this issue Nov 12, 2024 · 1 comment · Fixed by #14374
Closed

Deprecate Nest usage in @sentry/node #14242

mydea opened this issue Nov 12, 2024 · 1 comment · Fixed by #14374
Assignees
Labels
Package: node Issues related to the Sentry Node SDK
Milestone

Comments

@mydea
Copy link
Member

mydea commented Nov 12, 2024

Description

Users should use @sentry/nestjs instead of @sentry/node with the nest integration.

While the nest integration is automatically added, we can add a deprecation warning to setupNestErrorHandler when used from @sentry/node.

In v9, we'll remove the nest integration from @sentry/node, in favor of users using the nest SDK directly.

NOTE: We should only do this once we removed any beta warnings/labels from the Nest SDK.

NOTE by @lforst: This should likely also wait until #14292 is completed.

@lforst lforst changed the title Deprecate Nest usage in @sentry/node [v9] Deprecate Nest usage in @sentry/node Nov 13, 2024
@lforst lforst added this to the 9.0.0 milestone Nov 13, 2024
@lforst lforst changed the title [v9] Deprecate Nest usage in @sentry/node Deprecate Nest usage in @sentry/node Nov 13, 2024
@AbhiPrasad AbhiPrasad added the Package: node Issues related to the Sentry Node SDK label Nov 14, 2024
@lforst lforst self-assigned this Nov 15, 2024
lforst added a commit that referenced this issue Nov 15, 2024
Ref #14242

The NestJS SDK is stable enough for us to remove this label. All the
breaking changes we do to the SDK are gonna end up in v9.
Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was referenced by PR #14374, which was included in the 8.40.0 release.

onurtemizkan pushed a commit that referenced this issue Nov 22, 2024
Ref #14242

The NestJS SDK is stable enough for us to remove this label. All the
breaking changes we do to the SDK are gonna end up in v9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: node Issues related to the Sentry Node SDK
Projects
None yet
3 participants