Skip to content

Warn when null is returned from beforeSendSpan #14335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lforst opened this issue Nov 18, 2024 · 1 comment · Fixed by #14433
Closed

Warn when null is returned from beforeSendSpan #14335

lforst opened this issue Nov 18, 2024 · 1 comment · Fixed by #14433
Assignees
@chargome
Milestone
9.0.0

Comments

@lforst
Copy link
Member

lforst commented Nov 18, 2024

Description

There is a good chance we will disallow dropping individual spans soon. Reason being trace completeness and sampling changes in the product.

Options we can take:

  • Simply warn (once) when null is returned <- Currently preferred solution
  • Wipe the span when null is returned (and optionally warn)
@lforst lforst added this to the 9.0.0 milestone Nov 18, 2024
@lforst lforst mentioned this issue Nov 18, 2024
Closed
@chargome chargome self-assigned this Nov 21, 2024
This was referenced Nov 22, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was referenced by PR #14433, which was included in the 8.41.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chargome chargome

Labels
None yet
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

feat(core): Log warnings when returning null in beforeSendSpan getsentry/sentry-javascript
2 participants
@lforst @chargome