Skip to content

Add previous_trace span link to browserTracingIntegration root spans #14992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lms24 opened this issue Jan 13, 2025 · 1 comment · Fixed by #15569
Closed

Add previous_trace span link to browserTracingIntegration root spans #14992

Lms24 opened this issue Jan 13, 2025 · 1 comment · Fixed by #15569
Assignees

Comments

@Lms24
Copy link
Member

Lms24 commented Jan 13, 2025

Description

This task involves using the span link APIs introduced in #14991 to store a link to the local root span of the previous trace.

The rough implementation idea is outlined in the RFC but I'll note down the most important and some additional aspects:

  • Find a place to store the previous trace root span context (rootSpan.spanContext()). This could be on the isolation scope for example but I'll leave the decision happily to implementors
  • On span start, check if a valid previous trace root span context is stored and add a link to it
  • Right after, replace the previous trace root span context with the current root span context
  • A previous trace root span context is valid as long as it is not older than 15 minutes  1 hour (1h was chosen as a compromise of longevity and an efficient querying time window)

WIP; ref getsentry/rfcs#141

Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was referenced by PR #15569, which was included in the 9.9.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant