Skip to content

peer dependency of Pinia set to v2.x - breaks upgrading Pinia to v3 #15378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
eneeio-nm opened this issue Feb 12, 2025 · 2 comments · Fixed by #15383
Closed
3 tasks done

peer dependency of Pinia set to v2.x - breaks upgrading Pinia to v3 #15378

eneeio-nm opened this issue Feb 12, 2025 · 2 comments · Fixed by #15383
Assignees
Labels
Package: vue Issues related to the Sentry Vue SDK

Comments

@eneeio-nm
Copy link

eneeio-nm commented Feb 12, 2025

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/vue

SDK Version

9.0.1

Framework Version

Vue 3.5.13

Link to Sentry event

No response

Reproduction Example/SDK Setup

Now that Pinia v3 has been released, @sentry/vue causes upgrading due to:

npm error While resolving: @sentry/[email protected]
npm error Found: [email protected]
npm error node_modules/pinia
npm error   pinia@"3.0.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peerOptional pinia@"2.x" from @sentry/[email protected]
npm error node_modules/@sentry/vue
npm error   @sentry/vue@"9.0.1" from the root project
npm error
npm error Conflicting peer dependency: [email protected]
npm error node_modules/pinia
npm error   peerOptional pinia@"2.x" from @sentry/[email protected]
npm error   node_modules/@sentry/vue
npm error     @sentry/vue@"9.0.1" from the root project

Please can this be investigated and resolved?

Steps to Reproduce

  1. renovate generated a PR to upgrade Pinia to v3
  2. build failed due to peer dependency reliance on Pinia v2.x

Expected Result

Build should pass as there's no peer dependency reliance on Pinia v2.x

Actual Result

Build failed due to a peer dependency reliance on Pinia v2.x

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Feb 12, 2025
@github-actions github-actions bot added the Package: vue Issues related to the Sentry Vue SDK label Feb 12, 2025
@s1gr1d
Copy link
Member

s1gr1d commented Feb 12, 2025

Hello and thanks for raising this. Support for Pinia v3 will come with the next minor version of v8 and v9.

Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was referenced by PR #15383, which was included in the 9.1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: vue Issues related to the Sentry Vue SDK
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants