From 6a4d772d41310456bb0df460c19d66c774913140 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 27 Jan 2025 16:46:13 +0100 Subject: [PATCH 1/2] test(v8/e2e): Avoid making request to example.com in nextjs e2e test example.com still seems flaky, let's avoid making requests to it --- .../nextjs-14/app/request-instrumentation/page.tsx | 4 ++-- .../nextjs-14/tests/request-instrumentation.test.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dev-packages/e2e-tests/test-applications/nextjs-14/app/request-instrumentation/page.tsx b/dev-packages/e2e-tests/test-applications/nextjs-14/app/request-instrumentation/page.tsx index c11efda8adc9..b06521f2cb10 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-14/app/request-instrumentation/page.tsx +++ b/dev-packages/e2e-tests/test-applications/nextjs-14/app/request-instrumentation/page.tsx @@ -3,9 +3,9 @@ import http from 'http'; export const dynamic = 'force-dynamic'; export default async function Page() { - await fetch('http://example.com/', { cache: 'no-cache' }).then(res => res.text()); + await fetch('http://github.com/', { cache: 'no-cache' }).then(res => res.text()); await new Promise(resolve => { - http.get('http://example.com/', res => { + http.get('http://github.com/', res => { res.on('data', () => { // Noop consuming some data so that request can close :) }); diff --git a/dev-packages/e2e-tests/test-applications/nextjs-14/tests/request-instrumentation.test.ts b/dev-packages/e2e-tests/test-applications/nextjs-14/tests/request-instrumentation.test.ts index 65b9c4312d91..fc2feb101760 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-14/tests/request-instrumentation.test.ts +++ b/dev-packages/e2e-tests/test-applications/nextjs-14/tests/request-instrumentation.test.ts @@ -19,7 +19,7 @@ test('Should send a transaction with a fetch span', async ({ page }) => { 'sentry.op': 'http.client', 'sentry.origin': 'auto.http.otel.node_fetch', }), - description: 'GET http://example.com/', + description: 'GET http://github.com/', }), ); @@ -30,7 +30,7 @@ test('Should send a transaction with a fetch span', async ({ page }) => { 'sentry.op': 'http.client', 'sentry.origin': 'auto.http.otel.http', }), - description: 'GET http://example.com/', + description: 'GET http://github.com/', }), ); }); From cafa85ee8469922aa81566150fcd9e3ab6c529a2 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 27 Jan 2025 16:49:52 +0100 Subject: [PATCH 2/2] start ci