-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(tracing): Add origin
to spans
#8765
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding origin
to a transaction does nothing atm right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted the origins of all packages (mostly navigation and pageload ops)
this.data = spanContext.data || {}; | ||
this.instrumenter = spanContext.instrumenter || 'sentry'; | ||
this.origin = spanContext.origin || 'manual'; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l: (or no action required) we might wanna streamline some of the other assignments here as well but it's ouf of scope for this PR. feel free to ignore
It's not shown anywhere at least, as far as I can tell! |
This adds an
origin
to all spans, which defaults tomanual
but is set to something more meaningful for all our auto instrumentation.I tried to come up with reasonable origin names, I hope it makes sense everywhere 😅 Also note that this now uses a new TS feature which seems to be correctly transpiled to TS 3.8, as far as I can tell! 🎉
Closes #8510