Skip to content

Commit fc56ed6

Browse files
authored
feat: Pin JS SDK versions to v8 (#712)
1 parent b724bb9 commit fc56ed6

File tree

7 files changed

+31
-12
lines changed

7 files changed

+31
-12
lines changed

Diff for: .prettierrc

+13-5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
11
{
2-
"printWidth": 80,
3-
"proseWrap": "always",
4-
"singleQuote": true,
5-
"trailingComma": "all"
6-
}
2+
"printWidth": 80,
3+
"proseWrap": "always",
4+
"singleQuote": true,
5+
"trailingComma": "all",
6+
"overrides": [
7+
{
8+
"files": "CHANGELOG.md",
9+
"options": {
10+
"proseWrap": "preserve"
11+
}
12+
}
13+
]
14+
}

Diff for: CHANGELOG.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
## Unreleased
4+
5+
- feat: Pin JS SDK versions to v8 (#712)
6+
37
## 3.34.4
48

59
- chore(deps): Update various dependencies (#701, #700, #224)
@@ -16,7 +20,7 @@
1620
## 3.34.1
1721

1822
- fix(sveltekit): Ensure Sentry example page renders correct Html ([#688](https://github.com/getsentry/sentry-wizard/pull/688))
19-
- ref: Handle edge cases in formatting step more gracefully ([#687](https://github.com/getsentry/sentry-wizard/pull/686))
23+
- ref: Handle edge cases in formatting step more gracefully ([#687](https://github.com/getsentry/sentry-wizard/pull/686))
2024

2125
## 3.34.0
2226

Diff for: src/nextjs/nextjs-wizard.ts

+1
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ export async function runNextjsWizardWithTelemetry(
9494
const { packageManager: packageManagerFromInstallStep } =
9595
await installPackage({
9696
packageName: '@sentry/nextjs@^8',
97+
packageNameDisplayLabel: '@sentry/nextjs',
9798
alreadyInstalled: !!packageJson?.dependencies?.['@sentry/nextjs'],
9899
});
99100

Diff for: src/remix/remix-wizard.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,8 @@ async function runRemixWizardWithTelemetry(
7070
await getOrAskForProjectData(options, 'javascript-remix');
7171

7272
await installPackage({
73-
packageName: '@sentry/remix',
73+
packageName: '@sentry/remix@^8',
74+
packageNameDisplayLabel: '@sentry/remix',
7475
alreadyInstalled: hasPackageInstalled('@sentry/remix', packageJson),
7576
});
7677

Diff for: src/sourcemaps/tools/rollup.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export const configureRollupPlugin: SourceMapUploadToolConfigurationFunction =
5151

5252
clack.log.step(`Add the following code to your rollup config:`);
5353

54-
// Intentially logging directly to console here so that the code can be copied/pasted directly
54+
// Intentionally logging directly to console here so that the code can be copied/pasted directly
5555
// eslint-disable-next-line no-console
5656
console.log(getCodeSnippet(options));
5757

Diff for: src/sveltekit/sveltekit-wizard.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,8 @@ export async function runSvelteKitWizardWithTelemetry(
9595
Sentry.setTag('sdk-already-installed', sdkAlreadyInstalled);
9696

9797
await installPackage({
98-
packageName: '@sentry/sveltekit',
98+
packageName: '@sentry/sveltekit@^8',
99+
packageNameDisplayLabel: '@sentry/sveltekit',
99100
alreadyInstalled: sdkAlreadyInstalled,
100101
});
101102

Diff for: src/utils/clack-utils.ts

+7-3
Original file line numberDiff line numberDiff line change
@@ -354,17 +354,21 @@ export async function installPackage({
354354
packageName,
355355
alreadyInstalled,
356356
askBeforeUpdating = true,
357+
packageNameDisplayLabel,
357358
}: {
359+
/** The string that is passed to the package manager CLI as identifier to install (e.g. `@sentry/nextjs`, or `@sentry/nextjs@^8`) */
358360
packageName: string;
359361
alreadyInstalled: boolean;
360362
askBeforeUpdating?: boolean;
363+
/** Overrides what is shown in the installation logs in place of the `packageName` option. Useful if the `packageName` is ugly (e.g. `@sentry/nextjs@^8`) */
364+
packageNameDisplayLabel?: string;
361365
}): Promise<{ packageManager?: PackageManager }> {
362366
return traceStep('install-package', async () => {
363367
if (alreadyInstalled && askBeforeUpdating) {
364368
const shouldUpdatePackage = await abortIfCancelled(
365369
clack.confirm({
366370
message: `The ${chalk.bold.cyan(
367-
packageName,
371+
packageNameDisplayLabel ?? packageName,
368372
)} package is already installed. Do you want to update it to the latest version?`,
369373
}),
370374
);
@@ -380,7 +384,7 @@ export async function installPackage({
380384

381385
sdkInstallSpinner.start(
382386
`${alreadyInstalled ? 'Updating' : 'Installing'} ${chalk.bold.cyan(
383-
packageName,
387+
packageNameDisplayLabel ?? packageName,
384388
)} with ${chalk.bold(packageManager.label)}.`,
385389
);
386390

@@ -425,7 +429,7 @@ export async function installPackage({
425429

426430
sdkInstallSpinner.stop(
427431
`${alreadyInstalled ? 'Updated' : 'Installed'} ${chalk.bold.cyan(
428-
packageName,
432+
packageNameDisplayLabel ?? packageName,
429433
)} with ${chalk.bold(packageManager.label)}.`,
430434
);
431435

0 commit comments

Comments
 (0)