ref(alerts): add issue_type tag to notifications.sent metric (#88063)

In DD, this will allow us to aggregate by the
[GroupType](https://github.com/getsentry/sentry/blob/5510957c4ed7d7ad50f60b34d425c618cd15dd08/src/sentry/issues/grouptype.py#L155)
of issue alerts. We'll get counts for specific types and can create
detectors for them

Note: we'll have to enable aggregation for this specific tag in DD,
which will add some cost. There's a fixed number of group types defined
in grouptype.py.

Author: aliu39

src/sentry/integrations/discord/actions/issue_alert/notification.py

@@ -81,7 +81,14 @@ def send_notification(event: GroupEvent, futures: Sequence[RuleFuture]) -> None:
 
         key = f"discord:{integration.id}:{channel_id}"
 
-        metrics.incr("notifications.sent", instance="discord.notifications", skip_internal=False)
+        metrics.incr(
+            "notifications.sent",
+            instance="discord.notifications",
+            tags={
+                "issue_type": event.group.issue_type.slug,
+            },
+            skip_internal=False,
+        )
         yield self.future(send_notification, key=key)
 
     def render_label(self) -> str:

src/sentry/integrations/msteams/actions/notification.py

@@ -69,7 +69,14 @@ def send_notification(event, futures):
 
         key = f"msteams:{integration.id}:{channel}"
 
-        metrics.incr("notifications.sent", instance="msteams.notification", skip_internal=False)
+        metrics.incr(
+            "notifications.sent",
+            instance="msteams.notification",
+            tags={
+                "issue_type": event.group.issue_type.slug,
+            },
+            skip_internal=False,
+        )
         yield self.future(send_notification, key=key)
 
     def render_label(self):

src/sentry/integrations/slack/actions/notification.py

@@ -464,7 +464,14 @@ def send_notification_noa(event: GroupEvent, futures: Sequence[RuleFuture]) -> N
 
         key = f"slack:{integration.id}:{channel}"
 
-        metrics.incr("notifications.sent", instance="slack.notification", skip_internal=False)
+        metrics.incr(
+            "notifications.sent",
+            instance="slack.notification",
+            tags={
+                "issue_type": event.group.issue_type.slug,
+            },
+            skip_internal=False,
+        )
         if features.has("organizations:workflow-engine-trigger-actions", self.project.organization):
             yield self.future(send_notification_noa, key=key)
         else:

src/sentry/mail/actions.py

@@ -40,7 +40,6 @@ def after(self, event, notification_uuid: str | None = None):
             "group_id": group.id,
             "notification_uuid": notification_uuid,
         }
-        group = event.group
 
         target_type = ActionTargetType(self.data["targetType"])
         target_identifier = self.data.get("targetIdentifier", None)
@@ -59,7 +58,14 @@ def after(self, event, notification_uuid: str | None = None):
             self.logger.info("rule.fail.should_notify", extra=extra)
             return
 
-        metrics.incr("notifications.sent", instance=self.metrics_slug, skip_internal=False)
+        metrics.incr(
+            "notifications.sent",
+            instance=self.metrics_slug,
+            tags={
+                "issue_type": group.issue_type.slug,
+            },
+            skip_internal=False,
+        )
         yield self.future(
             lambda event, futures: mail_adapter.rule_notify(
                 event,

src/sentry/rules/actions/notify_event.py

@@ -38,5 +38,12 @@ def after(
             if not safe_execute(plugin.should_notify, group=group, event=event):
                 continue
 
-            metrics.incr("notifications.sent", instance=plugin.slug, skip_internal=False)
+            metrics.incr(
+                "notifications.sent",
+                instance=plugin.slug,
+                tags={
+                    "issue_type": event.group.issue_type.slug,
+                },
+                skip_internal=False,
+            )
             yield self.future(plugin.rule_notify)

src/sentry/rules/actions/notify_event_service.py

@@ -166,7 +166,14 @@ def after(
         app = app_service.get_sentry_app_by_slug(slug=service)
 
         if app:
-            metrics.incr("notifications.sent", instance=app.slug, skip_internal=False)
+            metrics.incr(
+                "notifications.sent",
+                instance=app.slug,
+                tags={
+                    "issue_type": event.group.issue_type.slug,
+                },
+                skip_internal=False,
+            )
             yield self.future(notify_sentry_app, sentry_app=app)
 
         try:
@@ -197,7 +204,14 @@ def after(
             extra["project_id"] = self.project.id
             self.logger.info("rules.plugin_notification_sent", extra=extra)
 
-            metrics.incr("notifications.sent", instance=plugin.slug, skip_internal=False)
+            metrics.incr(
+                "notifications.sent",
+                instance=plugin.slug,
+                tags={
+                    "issue_type": event.group.issue_type.slug,
+                },
+                skip_internal=False,
+            )
             yield self.future(plugin.rule_notify)
 
     def get_sentry_app_services(self) -> Sequence[RpcSentryAppService]: