chore(eslint): Enable and auto-fix prefer-array-index-of (#88047)

Author: ryan953

eslint.config.mjs

@@ -614,7 +614,7 @@ export default typescript.config([
       'unicorn/prefer-array-find': 'error',
       'unicorn/prefer-array-flat-map': 'error',
       'unicorn/prefer-array-flat': 'off', // TODO(ryan953): Fix violations and enable this rule
-      'unicorn/prefer-array-index-of': 'off', // TODO(ryan953): Fix violations and enable this rule
+      'unicorn/prefer-array-index-of': 'error',
       'unicorn/prefer-array-some': 'off', // TODO(ryan953): Fix violations and enable this rule
       'unicorn/prefer-date-now': 'error',
       'unicorn/prefer-default-parameters': 'warn', // TODO(ryan953): Fix violations and enable this rule

static/app/components/deprecatedSmartSearchBar/index.tsx

@@ -658,7 +658,8 @@ class DeprecatedSmartSearchBar extends Component<DefaultProps & Props, State> {
 
       let offset = filterTokens[0]!.location.end.offset;
       if (token) {
-        const tokenIndex = filterTokens.findIndex(tok => tok === token);
+        // @ts-expect-error: Mismatched types
+        const tokenIndex = filterTokens.indexOf(token);
         if (tokenIndex !== -1 && tokenIndex + 1 < filterTokens.length) {
           offset = filterTokens[tokenIndex + 1]!.location.end.offset;
         }
@@ -677,7 +678,8 @@ class DeprecatedSmartSearchBar extends Component<DefaultProps & Props, State> {
     const hasExecCommand = typeof document.execCommand === 'function';
 
     if (token && filterTokens.length > 0) {
-      const index = filterTokens.findIndex(tok => tok === token) ?? -1;
+      // @ts-expect-error: Mismatched types
+      const index = filterTokens.indexOf(token) ?? -1;
       const newQuery =
         // We trim to remove any remaining spaces
         query.slice(0, token.location.start.offset).trim() +

static/app/components/replays/useJumpButtons.tsx

@@ -28,7 +28,10 @@ export default function useJumpButtons({
       targetOffsetMs: currentTime,
       allowExact: true,
     });
-    const index = frames.findIndex(spanFrame => frame === spanFrame);
+    if (!frame) {
+      return frames.length - 1;
+    }
+    const index = frames.indexOf(frame);
     // index is -1 at end of replay, so use last index
     return index === -1 ? frames.length - 1 : index;
   }, [currentTime, frames]);

static/app/stores/selectedGroupStore.tsx

@@ -139,8 +139,8 @@ const storeConfig: SelectedGroupStoreDefinition = {
     }
 
     const ids = GroupStore.getAllItemIds();
-    const lastIdx = ids.findIndex(id => id === this.state.lastSelected);
-    const currentIdx = ids.findIndex(id => id === itemId);
+    const lastIdx = ids.indexOf(this.state.lastSelected);
+    const currentIdx = ids.indexOf(itemId);
 
     if (lastIdx === -1 || currentIdx === -1) {
       return;

static/app/views/dashboards/widgetBuilder/buildSteps/groupByStep/groupBySelector.tsx

@@ -129,9 +129,7 @@ export function GroupBySelector({
     }>(
       (acc, key) => {
         const value = fieldOptions[key]!;
-        const optionInColumnsIndex = columnFieldsAsString.findIndex(
-          column => column === value.value.meta.name
-        );
+        const optionInColumnsIndex = columnFieldsAsString.indexOf(value.value.meta.name);
         if (optionInColumnsIndex === -1) {
           acc.filteredFieldOptions[key] = value;
           return acc;

static/app/views/projectDetail/projectCharts.tsx

@@ -123,7 +123,7 @@ class ProjectCharts extends Component<Props, State> {
       .map(urlKey => {
         return decodeScalar(
           location.query[urlKey],
-          this.defaultDisplayModes[visibleCharts.findIndex(value => value === urlKey)]!
+          this.defaultDisplayModes[visibleCharts.indexOf(urlKey)]!
         );
       });
   }