chore: Prevent importing from gsAdmin & gsApp (#87666)

Author: ryan953

eslint.config.mjs

@@ -37,13 +37,6 @@ invariant(react.configs.flat, 'For typescript');
 invariant(react.configs.flat.recommended, 'For typescript');
 invariant(react.configs.flat['jsx-runtime'], 'For typescript');
 
-const restrictedImportPatterns = [
-  {
-    group: ['sentry/components/devtoolbar/*'],
-    message: 'Do not depend on toolbar internals',
-  },
-];
-
 const restrictedImportPaths = [
   {
     name: '@testing-library/react',
@@ -264,7 +257,23 @@ export default typescript.config([
       'no-proto': 'error',
       'no-restricted-imports': [
         'error',
-        {patterns: restrictedImportPatterns, paths: restrictedImportPaths},
+        {
+          patterns: [
+            {
+              group: ['admin/*'],
+              message: 'Do not import gsAdmin into sentry',
+            },
+            {
+              group: ['getsentry/*'],
+              message: 'Do not import gsApp into sentry',
+            },
+            {
+              group: ['sentry/components/devtoolbar/*'],
+              message: 'Do not depend on toolbar internals',
+            },
+          ],
+          paths: restrictedImportPaths,
+        },
       ],
       'no-return-assign': 'error',
       'no-script-url': 'error',
@@ -697,6 +706,16 @@ export default typescript.config([
       'no-restricted-imports': [
         'error',
         {
+          patterns: [
+            {
+              group: ['admin/*'],
+              message: 'Do not import gsAdmin into sentry',
+            },
+            {
+              group: ['getsentry/*'],
+              message: 'Do not import gsApp into sentry',
+            },
+          ],
           paths: [
             ...restrictedImportPaths,
             {
@@ -722,7 +741,20 @@ export default typescript.config([
       'no-restricted-imports': [
         'error',
         {
-          patterns: restrictedImportPatterns,
+          patterns: [
+            {
+              group: ['admin/*'],
+              message: 'Do not import gsAdmin into sentry',
+            },
+            {
+              group: ['getsentry/*'],
+              message: 'Do not import gsApp into sentry',
+            },
+            {
+              group: ['sentry/components/devtoolbar/*'],
+              message: 'Do not depend on toolbar internals',
+            },
+          ],
           paths: [
             ...restrictedImportPaths,
             {
@@ -751,4 +783,44 @@ export default typescript.config([
       'no-console': 'off',
     },
   },
+  {
+    name: 'files/gsApp',
+    files: ['static/gsApp/**/*.{js,mjs,ts,jsx,tsx}'],
+    rules: {
+      'no-restricted-imports': [
+        'error',
+        {
+          patterns: [
+            {
+              group: ['admin/*'],
+              message: 'Do not import gsAdmin into gsApp',
+            },
+            {
+              group: ['sentry/components/devtoolbar/*'],
+              message: 'Do not depend on toolbar internals',
+            },
+          ],
+          paths: restrictedImportPaths,
+        },
+      ],
+    },
+  },
+  {
+    name: 'files/gsAdmin',
+    files: ['static/gsAdmin/**/*.{js,mjs,ts,jsx,tsx}'],
+    rules: {
+      'no-restricted-imports': [
+        'error',
+        {
+          patterns: [
+            {
+              group: ['sentry/components/devtoolbar/*'],
+              message: 'Do not depend on toolbar internals',
+            },
+          ],
+          paths: restrictedImportPaths,
+        },
+      ],
+    },
+  },
 ]);

static/app/components/nav/primary/help.tsx

@@ -11,8 +11,6 @@ import useMutateUserOptions from 'sentry/utils/useMutateUserOptions';
 import useOrganization from 'sentry/utils/useOrganization';
 import {activateZendesk, zendeskIsLoaded} from 'sentry/utils/zendesk';
 
-import trackGetsentryAnalytics from 'getsentry/utils/trackGetsentryAnalytics';
-
 function getContactSupportItem({
   organization,
 }: {
@@ -30,7 +28,7 @@ function getContactSupportItem({
       label: t('Contact Support'),
       onAction() {
         activateZendesk();
-        trackGetsentryAnalytics('zendesk_link.clicked', {
+        trackAnalytics('zendesk_link.clicked', {
           organization,
           source: 'sidebar',
         });

static/app/views/explore/spans/spansTab.tsx

@@ -65,6 +65,7 @@ import {
 import {useOnboardingProject} from 'sentry/views/insights/common/queries/useOnboardingProject';
 import {Onboarding} from 'sentry/views/performance/onboarding';
 
+// eslint-disable-next-line no-restricted-imports
 import QuotaExceededAlert from 'getsentry/components/performance/quotaExceededAlert';
 
 export type SpanTabProps = {