fix(releases): fix newGroups calculation on release meta and remove usages of release new_groups (#88024)

- fixes #87322
- [notion
doc](https://www.notion.so/sentry/Removing-new_groups-field-from-Release-model-1c28b10e4b5d801d8598dd15e7a5b215?showMoveTo=true&saveParent=true)
for context & plan

on the `releases/meta/` endpoint, the value for `newGroups` incorrect,
as seen in this [API
request](https://sentry.sentry.io/api/0/organizations/sentry/releases/frontend%4085a177005793f32687cdd7d9776191ee51153e5f/meta/)
-- the project has 1 `newGroup` but the overall release meta `newGroups
== 0`.

the overall meta `newGroups` should be the same as the sum of
`newGroups` across all release projects, which this PR fixes.


https://github.com/getsentry/sentry/blob/b88166941846ce4fdb4e2001453e421b41ba7e10/tests/sentry/api/serializers/test_release.py#L76-L77

the `new_groups` field on the `Release` model was deprecated and will be
removed in a subsequent migration.


https://github.com/getsentry/sentry/blob/b88166941846ce4fdb4e2001453e421b41ba7e10/src/sentry/models/release.py#L210-L211

Author: michellewzhang

src/sentry/api/endpoints/organization_release_meta.py

@@ -104,7 +104,7 @@ def get(self, request: Request, organization, version) -> Response:
                 "version": release.version,
                 "versionInfo": expose_version_info(release.version_info),
                 "projects": projects,
-                "newGroups": release.new_groups,
+                "newGroups": sum(project["newGroups"] for project in projects),
                 "deployCount": release.total_deploys,
                 "commitCount": release.commit_count,
                 "released": release.date_released or release.date_added,

tests/sentry/api/endpoints/test_organization_release_meta.py

@@ -8,6 +8,7 @@
 from sentry.models.release import Release
 from sentry.models.releasecommit import ReleaseCommit
 from sentry.models.releasefile import ReleaseFile
+from sentry.models.releases.release_project import ReleaseProject
 from sentry.models.repository import Repository
 from sentry.testutils.cases import APITestCase
 
@@ -29,6 +30,9 @@ def test_multiple_projects(self):
         release.add_project(project)
         release.add_project(project2)
 
+        ReleaseProject.objects.filter(project=project, release=release).update(new_groups=10)
+        ReleaseProject.objects.filter(project=project2, release=release).update(new_groups=10)
+
         ReleaseFile.objects.create(
             organization_id=project.organization_id,
             release_id=release.id,
@@ -61,7 +65,6 @@ def test_multiple_projects(self):
 
         release.commit_count = 2
         release.total_deploys = 1
-        release.new_groups = 42
         release.save()
 
         self.create_member(teams=[team1, team2], user=user, organization=org)
@@ -79,7 +82,7 @@ def test_multiple_projects(self):
         data = orjson.loads(response.content)
         assert data["deployCount"] == 1
         assert data["commitCount"] == 2
-        assert data["newGroups"] == 42
+        assert data["newGroups"] == 20
         assert data["commitFilesChanged"] == 2
         assert data["releaseFileCount"] == 1
         assert len(data["projects"]) == 2

tests/sentry/api/serializers/test_release.py

@@ -202,7 +202,7 @@ def test_get_user_from_email(self):
         project = self.create_project()
         self.create_member(user=user, organization=project.organization)
         release = Release.objects.create(
-            organization_id=project.organization_id, version=uuid4().hex, new_groups=1
+            organization_id=project.organization_id, version=uuid4().hex
         )
         release.add_project(project)
         commit_author = CommitAuthor.objects.create(
@@ -242,7 +242,7 @@ def test_get_single_user_from_email(self):
         self.create_member(user=user, organization=project.organization)
         self.create_member(user=otheruser, organization=project.organization)
         release = Release.objects.create(
-            organization_id=project.organization_id, version=uuid4().hex, new_groups=1
+            organization_id=project.organization_id, version=uuid4().hex
         )
         release.add_project(project)
         commit_author = CommitAuthor.objects.create(
@@ -285,7 +285,7 @@ def test_select_user_from_appropriate_org(self):
         project = self.create_project()
         self.create_member(user=otheruser, organization=project.organization)
         release = Release.objects.create(
-            organization_id=project.organization_id, version=uuid4().hex, new_groups=1
+            organization_id=project.organization_id, version=uuid4().hex
         )
         release.add_project(project)
         commit_author = CommitAuthor.objects.create(
@@ -322,7 +322,7 @@ def test_no_commit_author(self):
         project = self.create_project()
         self.create_member(user=otheruser, organization=project.organization)
         release = Release.objects.create(
-            organization_id=project.organization_id, version=uuid4().hex, new_groups=1
+            organization_id=project.organization_id, version=uuid4().hex
         )
         release.add_project(project)
         commit = Commit.objects.create(
@@ -351,7 +351,7 @@ def test_deduplicate_users(self):
         project = self.create_project()
         self.create_member(user=user, organization=project.organization)
         release = Release.objects.create(
-            organization_id=project.organization_id, version=uuid4().hex, new_groups=1
+            organization_id=project.organization_id, version=uuid4().hex
         )
         release.add_project(project)
         commit_author1 = CommitAuthor.objects.create(
@@ -397,6 +397,7 @@ def test_deduplicate_users(self):
         result = serialize(release, user)
         assert len(result["authors"]) == 1
         assert result["authors"][0]["email"] == "[email protected]"
+        assert result["newGroups"] == 1
 
     def test_with_deploy(self):
         user = self.create_user()