fix(releases): fix summation of release meta newGroups

Author: michellewzhang

src/sentry/api/endpoints/organization_release_meta.py

@@ -104,7 +104,7 @@ def get(self, request: Request, organization, version) -> Response:
                 "version": release.version,
                 "versionInfo": expose_version_info(release.version_info),
                 "projects": projects,
-                "newGroups": release.new_groups,
+                "newGroups": sum(project["newGroups"] for project in projects),
                 "deployCount": release.total_deploys,
                 "commitCount": release.commit_count,
                 "released": release.date_released or release.date_added,

tests/sentry/api/endpoints/test_organization_release_meta.py

@@ -8,6 +8,7 @@
 from sentry.models.release import Release
 from sentry.models.releasecommit import ReleaseCommit
 from sentry.models.releasefile import ReleaseFile
+from sentry.models.releases.release_project import ReleaseProject
 from sentry.models.repository import Repository
 from sentry.testutils.cases import APITestCase
 
@@ -29,6 +30,9 @@ def test_multiple_projects(self):
         release.add_project(project)
         release.add_project(project2)
 
+        ReleaseProject.objects.filter(project=project, release=release).update(new_groups=10)
+        ReleaseProject.objects.filter(project=project2, release=release).update(new_groups=10)
+
         ReleaseFile.objects.create(
             organization_id=project.organization_id,
             release_id=release.id,
@@ -61,7 +65,7 @@ def test_multiple_projects(self):
 
         release.commit_count = 2
         release.total_deploys = 1
-        release.new_groups = 42
+        release.new_groups = 20
         release.save()
 
         self.create_member(teams=[team1, team2], user=user, organization=org)
@@ -79,11 +83,53 @@ def test_multiple_projects(self):
         data = orjson.loads(response.content)
         assert data["deployCount"] == 1
         assert data["commitCount"] == 2
-        assert data["newGroups"] == 42
+        assert data["newGroups"] == 20
         assert data["commitFilesChanged"] == 2
         assert data["releaseFileCount"] == 1
         assert len(data["projects"]) == 2
 
+    def test_favor_project_new_group_sum(self):
+        # test that the release meta `newGroups` field is the sum of the
+        # `newGroups` value across all projects, in the case that
+        # the release `newGroups` field is not the same value.
+
+        user = self.create_user(is_staff=False, is_superuser=False)
+        org = self.organization
+        org.flags.allow_joinleave = False
+        org.save()
+
+        team1 = self.create_team(organization=org)
+        team2 = self.create_team(organization=org)
+
+        project = self.create_project(teams=[team1], organization=org)
+        project2 = self.create_project(teams=[team2], organization=org)
+
+        release = Release.objects.create(organization_id=org.id, version="abcabcabc")
+        release.add_project(project)
+        release.add_project(project2)
+
+        ReleaseProject.objects.filter(project=project, release=release).update(new_groups=10)
+        ReleaseProject.objects.filter(project=project2, release=release).update(new_groups=10)
+
+        release.new_groups = 12  # incorrect value
+        release.save()
+
+        self.create_member(teams=[team1, team2], user=user, organization=org)
+        self.login_as(user=user)
+
+        url = reverse(
+            "sentry-api-0-organization-release-meta",
+            kwargs={"organization_id_or_slug": org.slug, "version": release.version},
+        )
+        response = self.client.get(url)
+
+        assert response.status_code == 200, response.content
+
+        data = orjson.loads(response.content)
+        # should be the sum of the `newGroups` values across all projects rather than release.new_groups
+        assert data["newGroups"] == 20
+        assert len(data["projects"]) == 2
+
     def test_artifact_count_without_weak_association(self):
         user = self.create_user(is_staff=False, is_superuser=False)
         org = self.organization