🔧 chore(aci): Organize Action Handler Directory (#88059)

## there is no logic change in this pr

### to review this pr, id recommend looking at the changes to the folder
structure
 
i have been running into a lot of circular dependency issues and merge
conflicts which stem from me stuffing everything in the action handler
directory.

with this pr, i bring some sense of organizations for actions and action
handlers:

1. we have generic action handlers that live in the workflow_engine
folder
2. other actions and registries live in a separate
`notifications/notification_action` folder organized by registry and
follow the same folder structure as workflow enginer

this will allow me to work quickly and keep things organized.

i also found some SOLID principle violations that i can fix in the
future.

## Before
```
workflow_engine/handlers/action/
├── __init__.py
├── __pycache__/
└── notification/
    ├── __init__.py
    ├── __pycache__/
    ├── handler.py
    ├── issue_alert.py
    └── metric_alert.py
```

## After
```
notifications/notification_action/
├── __init__.py
├── __pycache__/
├── exceptions.py
├── registry.py
├── types.py
├── utils.py
├── group_type_notification_registry/
│   ├── __init__.py
│   ├── __pycache__/
│   └── handlers/
├── issue_alert_registry/
│   ├── __init__.py
│   ├── __pycache__/
│   └── handlers/
└── metric_alert_registry/
    ├── __init__.py
    ├── __pycache__/
    └── handlers/
```
```
workflow_engine/handlers/action/
├── __init__.py
├── __pycache__/
└── notification/
    ├── __init__.py
    ├── __pycache__/
    ├── azure_devops_handler.py
    ├── base.py
    ├── common.py
    ├── discord_handler.py
    ├── email_handler.py
    ├── github_enterprise_handler.py
    ├── github_handler.py
    ├── jira_handler.py
    ├── jira_server_handler.py
    ├── msteams_handler.py
    ├── opsgenie_handler.py
    ├── pagerduty_handler.py
    ├── plugin_handler.py
    ├── sentry_app_handler.py
    ├── slack_handler.py
    └── webhook_handler.py
```

Author: iamrajjoshi

src/sentry/incidents/endpoints/serializers/workflow_engine_action.py

@@ -6,7 +6,9 @@
 )
 from sentry.incidents.models.alert_rule import AlertRuleTriggerAction
 from sentry.notifications.models.notificationaction import ActionService
-from sentry.workflow_engine.handlers.action.notification.handler import MetricAlertRegistryInvoker
+from sentry.notifications.notification_action.group_type_notification_registry.handlers.metric_alert_registry_handler import (
+    MetricAlertRegistryHandler,
+)
 from sentry.workflow_engine.models import Action, ActionAlertRuleTriggerAction
 
 
@@ -20,7 +22,7 @@ def serialize(self, obj: Action, attrs, user, **kwargs):
         aarta = ActionAlertRuleTriggerAction.objects.get(action=obj.id)
         priority = obj.data.get("priority")
         type_value = ActionService.get_value(obj.type)
-        target = MetricAlertRegistryInvoker.target(obj)
+        target = MetricAlertRegistryHandler.target(obj)
 
         target_type = obj.config.get("target_type")
         target_identifier = obj.config.get("target_identifier")

src/sentry/notifications/notification_action/__init__.py

@@ -0,0 +1,2 @@
+class NotificationHandlerException(Exception):
+    pass

src/sentry/notifications/notification_action/exceptions.py

@@ -0,0 +1,7 @@
+__all__ = [
+    "IssueAlertRegistryHandler",
+    "MetricAlertRegistryHandler",
+]
+
+from .handlers.issue_alert_registry_handler import IssueAlertRegistryHandler
+from .handlers.metric_alert_registry_handler import MetricAlertRegistryHandler

src/sentry/notifications/notification_action/group_type_notification_registry/__init__.py

@@ -0,0 +1,36 @@
+import logging
+
+from sentry.grouping.grouptype import ErrorGroupType
+from sentry.notifications.notification_action.exceptions import NotificationHandlerException
+from sentry.notifications.notification_action.registry import (
+    group_type_notification_registry,
+    issue_alert_handler_registry,
+)
+from sentry.notifications.notification_action.types import LegacyRegistryHandler
+from sentry.utils.registry import NoRegistrationExistsError
+from sentry.workflow_engine.models import Action, Detector
+from sentry.workflow_engine.types import WorkflowEventData
+
+logger = logging.getLogger(__name__)
+
+
+@group_type_notification_registry.register(ErrorGroupType.slug)
+class IssueAlertRegistryHandler(LegacyRegistryHandler):
+    @staticmethod
+    def handle_workflow_action(job: WorkflowEventData, action: Action, detector: Detector) -> None:
+        try:
+            handler = issue_alert_handler_registry.get(action.type)
+            handler.invoke_legacy_registry(job, action, detector)
+        except NoRegistrationExistsError:
+            logger.exception(
+                "No issue alert handler found for action type: %s",
+                action.type,
+                extra={"action_id": action.id},
+            )
+            raise
+        except Exception as e:
+            logger.exception(
+                "Error invoking issue alert handler",
+                extra={"action_id": action.id},
+            )
+            raise NotificationHandlerException(e)

src/sentry/notifications/notification_action/group_type_notification_registry/handlers/issue_alert_registry_handler.py

@@ -0,0 +1,63 @@
+import logging
+
+from sentry.issues.grouptype import MetricIssuePOC
+from sentry.models.organizationmember import OrganizationMember
+from sentry.models.team import Team
+from sentry.notifications.models.notificationaction import ActionTarget
+from sentry.notifications.notification_action.exceptions import NotificationHandlerException
+from sentry.notifications.notification_action.registry import (
+    group_type_notification_registry,
+    metric_alert_handler_registry,
+)
+from sentry.notifications.notification_action.types import LegacyRegistryHandler
+from sentry.utils.registry import NoRegistrationExistsError
+from sentry.workflow_engine.models import Action, DataConditionGroupAction, Detector
+from sentry.workflow_engine.types import WorkflowEventData
+
+logger = logging.getLogger(__name__)
+
+
+@group_type_notification_registry.register(MetricIssuePOC.slug)
+class MetricAlertRegistryHandler(LegacyRegistryHandler):
+    @staticmethod
+    def handle_workflow_action(job: WorkflowEventData, action: Action, detector: Detector) -> None:
+        try:
+            handler = metric_alert_handler_registry.get(action.type)
+            handler.invoke_legacy_registry(job, action, detector)
+        except NoRegistrationExistsError:
+            logger.exception(
+                "No metric alert handler found for action type: %s",
+                action.type,
+                extra={"action_id": action.id},
+            )
+            raise
+        except Exception as e:
+            logger.exception(
+                "Error invoking metric alert handler",
+                extra={"action_id": action.id},
+            )
+            raise NotificationHandlerException(e)
+
+    @staticmethod
+    def target(action: Action) -> OrganizationMember | Team | str | None:
+        target_identifier = action.config.get("target_identifier")
+        if target_identifier is None:
+            return None
+
+        target_type = action.config.get("target_type")
+        if target_type == ActionTarget.USER.value:
+            dcga = DataConditionGroupAction.objects.get(action=action)
+            return OrganizationMember.objects.get(
+                user_id=int(target_identifier),
+                organization=dcga.condition_group.organization,
+            )
+        elif target_type == ActionTarget.TEAM.value:
+            try:
+                return Team.objects.get(id=int(target_identifier))
+            except Team.DoesNotExist:
+                pass
+        elif target_type == ActionTarget.SPECIFIC.value:
+            # TODO: This is only for email. We should have a way of validating that it's
+            # ok to contact this email.
+            return target_identifier
+        return None

src/sentry/notifications/notification_action/group_type_notification_registry/handlers/metric_alert_registry_handler.py

@@ -0,0 +1,32 @@
+__all__ = [
+    "AzureDevopsIssueAlertHandler",
+    "DiscordIssueAlertHandler",
+    "EmailIssueAlertHandler",
+    "GithubIssueAlertHandler",
+    "GithubEnterpriseIssueAlertHandler",
+    "JiraIssueAlertHandler",
+    "JiraServerIssueAlertHandler",
+    "MSTeamsIssueAlertHandler",
+    "OpsgenieIssueAlertHandler",
+    "PagerdutyIssueAlertHandler",
+    "PluginIssueAlertHandler",
+    "SentryAppIssueAlertHandler",
+    "SlackIssueAlertHandler",
+    "WebhookIssueAlertHandler",
+    "PagerDutyIssueAlertHandler",
+]
+
+from .handlers.azure_devops_issue_alert_handler import AzureDevopsIssueAlertHandler
+from .handlers.discord_issue_alert_handler import DiscordIssueAlertHandler
+from .handlers.email_issue_alert_handler import EmailIssueAlertHandler
+from .handlers.github_enterprise_issue_alert_handler import GithubEnterpriseIssueAlertHandler
+from .handlers.github_issue_alert_handler import GithubIssueAlertHandler
+from .handlers.jira_issue_alert_handler import JiraIssueAlertHandler
+from .handlers.jira_server_issue_alert_handler import JiraServerIssueAlertHandler
+from .handlers.msteams_issue_alert_handler import MSTeamsIssueAlertHandler
+from .handlers.opsgenie_issue_alert_handler import OpsgenieIssueAlertHandler
+from .handlers.pagerduty_issue_alert_handler import PagerDutyIssueAlertHandler
+from .handlers.plugin_issue_alert_handler import PluginIssueAlertHandler
+from .handlers.sentry_app_issue_alert_handler import SentryAppIssueAlertHandler
+from .handlers.slack_issue_alert_handler import SlackIssueAlertHandler
+from .handlers.webhook_issue_alert_handler import WebhookIssueAlertHandler

src/sentry/notifications/notification_action/issue_alert_registry/__init__.py

@@ -0,0 +1,8 @@
+from sentry.notifications.notification_action.registry import issue_alert_handler_registry
+from sentry.notifications.notification_action.types import TicketingIssueAlertHandler
+from sentry.workflow_engine.models import Action
+
+
+@issue_alert_handler_registry.register(Action.Type.AZURE_DEVOPS)
+class AzureDevopsIssueAlertHandler(TicketingIssueAlertHandler):
+    pass

src/sentry/notifications/notification_action/issue_alert_registry/handlers/azure_devops_issue_alert_handler.py

@@ -0,0 +1,18 @@
+from typing import Any
+
+from sentry.notifications.notification_action.registry import issue_alert_handler_registry
+from sentry.notifications.notification_action.types import BaseIssueAlertHandler
+from sentry.workflow_engine.models import Action
+from sentry.workflow_engine.typings.notification_action import ActionFieldMapping, DiscordDataBlob
+
+
+@issue_alert_handler_registry.register(Action.Type.DISCORD)
+class DiscordIssueAlertHandler(BaseIssueAlertHandler):
+    @classmethod
+    def get_additional_fields(cls, action: Action, mapping: ActionFieldMapping) -> dict[str, Any]:
+        blob = DiscordDataBlob(**action.data)
+        return {"tags": blob.tags}
+
+    @classmethod
+    def get_target_display(cls, action: Action, mapping: ActionFieldMapping) -> dict[str, Any]:
+        return {}

src/sentry/notifications/notification_action/issue_alert_registry/handlers/discord_issue_alert_handler.py

@@ -0,0 +1,57 @@
+from typing import Any
+
+from sentry.notifications.models.notificationaction import ActionTarget
+from sentry.notifications.notification_action.registry import issue_alert_handler_registry
+from sentry.notifications.notification_action.types import BaseIssueAlertHandler
+from sentry.workflow_engine.models import Action
+from sentry.workflow_engine.typings.notification_action import (
+    ActionFieldMapping,
+    ActionFieldMappingKeys,
+    EmailActionHelper,
+    EmailDataBlob,
+    EmailFieldMappingKeys,
+)
+
+
+@issue_alert_handler_registry.register(Action.Type.EMAIL)
+class EmailIssueAlertHandler(BaseIssueAlertHandler):
+    @classmethod
+    def get_integration_id(cls, action: Action, mapping: ActionFieldMapping) -> dict[str, Any]:
+        return {}
+
+    @classmethod
+    def get_target_display(cls, action: Action, mapping: ActionFieldMapping) -> dict[str, Any]:
+        return {}
+
+    @classmethod
+    def get_target_identifier(
+        cls, action: Action, mapping: ActionFieldMapping, organization_id: int
+    ) -> dict[str, Any]:
+        target_id = action.config.get("target_identifier")
+        target_type = action.config.get("target_type")
+
+        # this would be when the target_type is IssueOwners
+        if target_id is None:
+            if target_type != ActionTarget.ISSUE_OWNERS.value:
+                raise ValueError(
+                    f"No target identifier found for {action.type} action {action.id}, target_type: {target_type}"
+                )
+            return {}
+        else:
+            return {mapping[ActionFieldMappingKeys.TARGET_IDENTIFIER_KEY.value]: target_id}
+
+    @classmethod
+    def get_additional_fields(cls, action: Action, mapping: ActionFieldMapping) -> dict[str, Any]:
+        target_type = ActionTarget(action.config.get("target_type"))
+
+        final_blob = {
+            EmailFieldMappingKeys.TARGET_TYPE_KEY.value: EmailActionHelper.get_target_type_string(
+                target_type
+            ),
+        }
+
+        if target_type == ActionTarget.ISSUE_OWNERS.value:
+            blob = EmailDataBlob(**action.data)
+            final_blob[EmailFieldMappingKeys.FALLTHROUGH_TYPE_KEY.value] = blob.fallthroughType
+
+        return final_blob

src/sentry/notifications/notification_action/issue_alert_registry/handlers/email_issue_alert_handler.py

@@ -0,0 +1,8 @@
+from sentry.notifications.notification_action.registry import issue_alert_handler_registry
+from sentry.notifications.notification_action.types import TicketingIssueAlertHandler
+from sentry.workflow_engine.models import Action
+
+
+@issue_alert_handler_registry.register(Action.Type.GITHUB_ENTERPRISE)
+class GithubEnterpriseIssueAlertHandler(TicketingIssueAlertHandler):
+    pass

src/sentry/notifications/notification_action/issue_alert_registry/handlers/github_enterprise_issue_alert_handler.py

@@ -0,0 +1,8 @@
+from sentry.notifications.notification_action.registry import issue_alert_handler_registry
+from sentry.notifications.notification_action.types import TicketingIssueAlertHandler
+from sentry.workflow_engine.models import Action
+
+
+@issue_alert_handler_registry.register(Action.Type.GITHUB)
+class GithubIssueAlertHandler(TicketingIssueAlertHandler):
+    pass

src/sentry/notifications/notification_action/issue_alert_registry/handlers/github_issue_alert_handler.py

@@ -0,0 +1,8 @@
+from sentry.notifications.notification_action.registry import issue_alert_handler_registry
+from sentry.notifications.notification_action.types import TicketingIssueAlertHandler
+from sentry.workflow_engine.models import Action
+
+
+@issue_alert_handler_registry.register(Action.Type.JIRA)
+class JiraIssueAlertHandler(TicketingIssueAlertHandler):
+    pass

src/sentry/notifications/notification_action/issue_alert_registry/handlers/jira_issue_alert_handler.py

@@ -0,0 +1,8 @@
+from sentry.notifications.notification_action.registry import issue_alert_handler_registry
+from sentry.notifications.notification_action.types import TicketingIssueAlertHandler
+from sentry.workflow_engine.models import Action
+
+
+@issue_alert_handler_registry.register(Action.Type.JIRA_SERVER)
+class JiraServerIssueAlertHandler(TicketingIssueAlertHandler):
+    pass

src/sentry/notifications/notification_action/issue_alert_registry/handlers/jira_server_issue_alert_handler.py

@@ -0,0 +1,8 @@
+from sentry.notifications.notification_action.registry import issue_alert_handler_registry
+from sentry.notifications.notification_action.types import BaseIssueAlertHandler
+from sentry.workflow_engine.models import Action
+
+
+@issue_alert_handler_registry.register(Action.Type.MSTEAMS)
+class MSTeamsIssueAlertHandler(BaseIssueAlertHandler):
+    pass

src/sentry/notifications/notification_action/issue_alert_registry/handlers/msteams_issue_alert_handler.py

@@ -0,0 +1,18 @@
+from typing import Any
+
+from sentry.notifications.notification_action.registry import issue_alert_handler_registry
+from sentry.notifications.notification_action.types import BaseIssueAlertHandler
+from sentry.workflow_engine.models import Action
+from sentry.workflow_engine.typings.notification_action import ActionFieldMapping, OnCallDataBlob
+
+
+@issue_alert_handler_registry.register(Action.Type.OPSGENIE)
+class OpsgenieIssueAlertHandler(BaseIssueAlertHandler):
+    @classmethod
+    def get_target_display(cls, action: Action, mapping: ActionFieldMapping) -> dict[str, Any]:
+        return {}
+
+    @classmethod
+    def get_additional_fields(cls, action: Action, mapping: ActionFieldMapping) -> dict[str, Any]:
+        blob = OnCallDataBlob(**action.data)
+        return {"priority": blob.priority}

src/sentry/notifications/notification_action/issue_alert_registry/handlers/opsgenie_issue_alert_handler.py

@@ -0,0 +1,18 @@
+from typing import Any
+
+from sentry.notifications.notification_action.registry import issue_alert_handler_registry
+from sentry.notifications.notification_action.types import BaseIssueAlertHandler
+from sentry.workflow_engine.models import Action
+from sentry.workflow_engine.typings.notification_action import ActionFieldMapping, OnCallDataBlob
+
+
+@issue_alert_handler_registry.register(Action.Type.PAGERDUTY)
+class PagerDutyIssueAlertHandler(BaseIssueAlertHandler):
+    @classmethod
+    def get_target_display(cls, action: Action, mapping: ActionFieldMapping) -> dict[str, Any]:
+        return {}
+
+    @classmethod
+    def get_additional_fields(cls, action: Action, mapping: ActionFieldMapping) -> dict[str, Any]:
+        blob = OnCallDataBlob(**action.data)
+        return {"severity": blob.priority}

src/sentry/notifications/notification_action/issue_alert_registry/handlers/pagerduty_issue_alert_handler.py

@@ -0,0 +1,23 @@
+from typing import Any
+
+from sentry.notifications.notification_action.registry import issue_alert_handler_registry
+from sentry.notifications.notification_action.types import BaseIssueAlertHandler
+from sentry.workflow_engine.models import Action
+from sentry.workflow_engine.typings.notification_action import ActionFieldMapping
+
+
+@issue_alert_handler_registry.register(Action.Type.PLUGIN)
+class PluginIssueAlertHandler(BaseIssueAlertHandler):
+    @classmethod
+    def get_integration_id(cls, action: Action, mapping: ActionFieldMapping) -> dict[str, Any]:
+        return {}
+
+    @classmethod
+    def get_target_identifier(
+        cls, action: Action, mapping: ActionFieldMapping, organization_id: int
+    ) -> dict[str, Any]:
+        return {}
+
+    @classmethod
+    def get_target_display(cls, action: Action, mapping: ActionFieldMapping) -> dict[str, Any]:
+        return {}