Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve issue stream errors #80166

Closed
mrduncan opened this issue Nov 1, 2024 · 2 comments · Fixed by #87691
Closed

Improve issue stream errors #80166

mrduncan opened this issue Nov 1, 2024 · 2 comments · Fixed by #87691
Assignees
@yuvmen
Labels
Product Area: Issues

Comments

@mrduncan
Copy link
Member

mrduncan commented Nov 1, 2024 •
edited
Loading

Problem Statement

When a PostgreSQL query times out, ex: SENTRY-3867, the issue stream currently just shows "Internal error":

Image

This is also a problem for queries throttled by Snuba, the "expected available in 1 second" is not accurate:

Image

Solution Brainstorm

We should show a more helpful message in these scenarios similar to other product areas which ask the user to scope down their query and/or try again depending on the failure which occurred.

Product Area

Issues
@getsantry
Copy link
Contributor

getsantry bot commented Nov 2, 2024

Routing to @getsentry/product-owners-issues for triage ⏲️

@linear linear bot added the Migrated label Jan 9, 2025
@mrduncan mrduncan changed the title Improve issue stream timeout errors Improve issue stream errors Feb 28, 2025
@JoshFerge
Copy link
Member

#86155 Helps on the snuba side. but more work to be done to return accurate rate limit information to the client.

@gaprl gaprl removed the Migrated label Mar 5, 2025
@yuvmen yuvmen self-assigned this Mar 24, 2025
yuvmen added a commit that referenced this issue Mar 24, 2025
@yuvmen
fix(issues): Replace Interal Error message on Postgres query timeout …
f558517 
…errors

Handle Postgres statement timeout errors on issue search which previously displayed 'Internal Error' but
will now show more appropriate message explaining the query took too long and to possibly revise it

Closes: #80166
yuvmen added a commit that referenced this issue Mar 24, 2025
@yuvmen
fix(issues): Replace 'Internal' Error message on Postgres query timeo…
af22570 
…ut errors

Handle Postgres statement timeout errors on issue search which previously displayed 'Internal Error' but
will now show more appropriate message explaining the query took too long and to possibly revise it

Closes: #80166
yuvmen added a commit that referenced this issue Mar 24, 2025
@yuvmen
fix(issues): Replace 'Internal Error' message on Postgres query timeo…
ee0dd55 
…ut errors

Handle Postgres statement timeout errors on issue search which previously displayed 'Internal Error' but
will now show more appropriate message explaining the query took too long and to possibly revise it

Closes: #80166
@yuvmen yuvmen mentioned this issue Mar 24, 2025
Merged
yuvmen added a commit that referenced this issue Mar 24, 2025
@yuvmen
fix(issues): Replace 'Internal Error' message on Postgres query timeo…
5886cc2 
…ut errors

Handle Postgres statement timeout errors on issue search which previously displayed 'Internal Error' but
will now show more appropriate message explaining the query took too long and to possibly revise it

Closes: #80166
@yuvmen yuvmen closed this as completed in 339fc4f Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuvmen yuvmen

Labels
Product Area: Issues
Projects
GitHub Issues with 👀 3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(issues): Replace 'Internal Error' message on Postgres query timeout errors getsentry/sentry
4 participants
@mrduncan @gaprl @JoshFerge @yuvmen