Skip to content

Commit 90e2755

Browse files
authored
Merge branch 'main' into dependabot/gradle/org.openapi.generator-7.8.0
2 parents 9c4bdbd + 297d3d6 commit 90e2755

File tree

6 files changed

+52
-10
lines changed

6 files changed

+52
-10
lines changed

CHANGELOG.md

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,26 @@
44

55
## [Unreleased]
66

7+
## [2.2.1] - 2024-09-24
8+
9+
### Fixed
10+
11+
- Ignore unknownError related to ConcurrentModificationException ([#137](https://github.com/getyourguide/openapi-validation-java/pull/137))
12+
13+
### Changed
14+
15+
- Updated several dependencies
16+
17+
## [2.2.0] - 2024-08-27
18+
19+
### Added
20+
21+
- Exclude graphql endpoints from validation by default ([#129](https://github.com/getyourguide/openapi-validation-java/pull/129))
22+
23+
### Changed
24+
25+
- Updated several dependencies
26+
727
## [2.1.0] - 2024-06-03
828

929
### Added
@@ -165,7 +185,9 @@
165185
- Initial squashed GitHub public release.
166186

167187

168-
[unreleased]: https://github.com/getyourguide/openapi-validation-java/compare/v2.1.0...HEAD
188+
[unreleased]: https://github.com/getyourguide/openapi-validation-java/compare/v2.2.1...HEAD
189+
[2.2.1]: https://github.com/getyourguide/openapi-validation-java/releases/tag/v2.2.1
190+
[2.2.0]: https://github.com/getyourguide/openapi-validation-java/releases/tag/v2.2.0
169191
[2.1.0]: https://github.com/getyourguide/openapi-validation-java/releases/tag/v2.1.0
170192
[2.0.3]: https://github.com/getyourguide/openapi-validation-java/releases/tag/v2.0.3
171193
[2.0.2]: https://github.com/getyourguide/openapi-validation-java/releases/tag/v2.0.2

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ apply from: "${rootDir}/gradle/publish-root.gradle"
1010
allprojects {
1111
group = 'com.getyourguide.openapi.validation'
1212
description = 'OpenAPI Validation library'
13-
version = '2.1.0'
13+
version = '2.2.1'
1414

1515
java {
1616
toolchain {

gradle/libs.versions.toml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11
[versions]
2-
spring-boot = "3.3.3"
2+
spring-boot = "3.3.4"
33
spring-dependency-management = "1.1.6"
44
openapi-generator = "7.8.0"
55
openapi-tools = "0.2.6"
6-
swagger = "2.2.22"
7-
swagger-request-validator = "2.41.0"
6+
swagger = "2.2.25"
7+
swagger-request-validator = "2.43.0"
88
jakarta-validation = "3.1.0"
99
lombok = "1.18.34"
1010
commons-codec = "1.17.1"
1111
find-bugs = "3.0.2"
1212
gradle-nexus-publish-plugin = "2.0.0"
13-
datadog-statsd = "4.4.2"
13+
datadog-statsd = "4.4.3"
1414
# Verify
1515
checkstyle = "8.44"
1616
pmd = "6.55.0"
1717
jacoco = "0.8.7"
1818
# Testing
19-
mockito = "5.12.0"
20-
junit-jupiter = "5.11.0"
19+
mockito = "5.14.2"
20+
junit-jupiter = "5.11.3"
2121

2222
[libraries]
2323
openapi-tools-jacksonDatabindNullable = { group = "org.openapitools", name = "jackson-databind-nullable", version.ref = "openapi-tools" }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-8.1.1-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-bin.zip
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists

openapi-validation-core/src/main/java/com/getyourguide/openapi/validation/core/exclusions/InternalViolationExclusions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ private boolean falsePositive406(OpenApiViolation violation) {
5858
}
5959

6060
private boolean isConcurrentModificationExceptionInLibrary(OpenApiViolation violation) {
61-
return "validation.response.body.schema.unknownError".equals(violation.getRule())
61+
return violation.getRule() != null && violation.getRule().endsWith(".body.schema.unknownError")
6262
&& violation.getMessage().contains("java.util.ConcurrentModificationException");
6363
}
6464
}

openapi-validation-core/src/test/java/com/getyourguide/openapi/validation/core/exclusions/InternalViolationExclusionsTest.java

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,26 @@ public void when406ResponseCodeWithStatusUnknownViolationThenViolationExcluded()
159159
.build());
160160
}
161161

162+
@Test
163+
public void whenUnknownErrorWithConcurrentModificationExceptionThenViolationExcluded() {
164+
when(customViolationExclusions.isExcluded(any())).thenReturn(false);
165+
String message =
166+
"An error occurred during schema validation - com.google.common.util.concurrent.UncheckedExecutionException: java.util.ConcurrentModificationException.";
167+
168+
checkViolationExcluded(OpenApiViolation.builder()
169+
.direction(Direction.RESPONSE)
170+
.rule("validation.request.body.schema.unknownError")
171+
.responseStatus(200)
172+
.message(message)
173+
.build());
174+
checkViolationExcluded(OpenApiViolation.builder()
175+
.direction(Direction.RESPONSE)
176+
.rule("validation.response.body.schema.unknownError")
177+
.responseStatus(200)
178+
.message(message)
179+
.build());
180+
}
181+
162182
private void checkViolationNotExcluded(OpenApiViolation violation) {
163183
var isExcluded = violationExclusions.isExcluded(violation);
164184

0 commit comments

Comments
 (0)