Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared library for redistribution #1086

Open
Kreijstal opened this issue Jan 25, 2025 · 5 comments
Open

Shared library for redistribution #1086

Kreijstal opened this issue Jan 25, 2025 · 5 comments

Comments

@Kreijstal
Copy link

Any plans of tagging releases of this?

@Kreijstal Kreijstal changed the title Shared library Shared library for redistribution Jan 25, 2025
@ggerganov
Copy link
Member

Definitely will start versioning and tagging. Still figuring out the details and hope to set this in action soon.

@JohannesGaessler
Copy link
Collaborator

How strict would versioning be regarding breaking changes?

@slaren
Copy link
Member

slaren commented Jan 25, 2025

We should use semantic versioning to indicate breaking changes.

@JohannesGaessler
Copy link
Collaborator

What I mean is: do we count all headers and modules for when to increment versions? The core ggml interface is I think relatively mature and I don't expect a lot of breaking changes. But for the training code in particular I think there will still be a lot of changes. Should we increment the overall ggml version to indicate a breaking change in that scenario or should we define breaking changes to only count depending on whether a specific part of the library is considered to be stable?

@slaren
Copy link
Member

slaren commented Jan 25, 2025

I don't think there are any specific plans about how to implement this. I guess at least we will need to make a new release when features are added to ggml that are used in llama.cpp or whisper.cpp, since one of the goals is being able to use the same libraries for both of these projects, as well as possibly other projects such as sd.cpp, if they choose to use the versioned libraries. So we will probably need to tag a new release and bump the major version even for incompatible changes to experimental features, if these are used in llama.cpp. That should be fine though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants